fix(watcher): honor 'watched: false' in patterns. #620
Conversation
Includes the patterns for files to include, but not to watch, in addition to the excludes list when creating a list of patterns to ignore. This makes the watcher ignore patterns marked as "watched: false" in karma's configuration file. Closes: karma-runner#616
|
Thanks @joakimkarlsson ! |
| @@ -45,20 +46,25 @@ var watchPatterns = function(patterns, watcher) { | |||
| // Function to test if an item is on the exclude list | |||
| // and therefore should not be watched by chokidar | |||
| // TODO(vojta): ignore non-matched files as well | |||
| var createIgnore = function(excludes) { | |||
| var createIgnore = function(excludes, patterns) { | |||
| var ex = _(patterns) | |||
There was a problem hiding this comment.
why do you need lodash ?
There was a problem hiding this comment.
oh, I see, the map('pattern'), ignore my previous comment
|
@joakimkarlsson thanks, this is a very nice PR ! I think we should change the algorithm to: I believe your current solution would fail this test: files = [
{pattern: 'src/one.js', watched: true},
{pattern: 'src/*.js', watched: false}
];This should watch There is a problem with my suggestion though - we need to NOT ignore directories, so we need implement this first paulmillr/chokidar#51 |
ghost
assigned
|
@joakimkarlsson I finally looked into it and I hope it's fixed in 6a272aa I changed chokidar to check "ignored" after having the stat and changed the watching/ignoring algorithm as described above. This should significantly improve performance. I'm closing this PR. Thanks for bringing this up @joakimkarlsson ! |
Includes the patterns for files to include, but not to watch, in
addition to the excludes list when creating a list of patterns
to ignore. This makes the watcher ignore patterns marked as
"watched: false" in karma's configuration file.
Closes: #616