chore(tests): advance the future time by 1000 yrs #3410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Build karma 2461 completed (commit fd783a8328 by @johnjbarton) |
|
✅ Build karma 63 completed (commit 57b69f4e70 by @johnjbarton) |
|
✅ Build karma 62 completed (commit fd783a8328 by @johnjbarton) |
kyliau
approved these changes
Jan 22, 2020
| @@ -596,13 +596,13 @@ describe('FileList', () => { | |||
| emitter.on('file_list_modified', modified) | |||
|
|
|||
| return list.refresh().then((files) => { | |||
| mockFs._touchFile('/some/b.js', '2020-01-01') | |||
| mockFs._touchFile('/some/b.js', '3020-01-01') | |||
There was a problem hiding this comment.
this is advancing the future time by 1000 years. The commit message needs to be updated. Please also update the PR description.
5 years ago some one set the test file time to 2020. And here we are.
johnjbarton
changed the title
|
✅ Build karma 65 completed (commit 684f2a95ae by @johnjbarton) |
|
🎉 This PR is included in version 5.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Jan 8, 2021
This was referenced May 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5 years ago someone set the test file time to 2020. And here we are.