feat(deps): Remove core-js dependency. #3379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The core-js was used for dom-serialize, used to support a single function in stringify (serialize) for a single rare browser, IE8, in logs sent back to the server. By dropping this dependency we reduce the size of karma with minimal impact on use cases.
|
✅ Build karma 14 completed (commit 9098175093 by @johnjbarton) |
|
✅ Build karma 2412 completed (commit 9098175093 by @johnjbarton) |
|
✅ Build karma 13 completed (commit 9098175093 by @johnjbarton) |
kyliau
approved these changes
Oct 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The core-js was used for dom-serialize, used to support a single function
in stringify (serialize) for a single rare browser, IE8, in logs sent back to
the server. By dropping this dependency we reduce the size of karma with
minimal impact on use cases.