Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup dependencies #3309

Merged
merged 2 commits into from
May 17, 2019
Merged

Cleanup dependencies #3309

merged 2 commits into from
May 17, 2019

Conversation

devoto13
Copy link
Collaborator

  • Removed devDependencies, which are not used by the codebase.
  • Updated most of the remaining devDependencies to latest versions.

devoto13
devoto13 commented May 16, 2019
View reviewed changes
test/e2e/reconnecting.feature
@@ -12,6 +12,11 @@ Feature: Passing Options
'karma-jasmine',
'karma-chrome-launcher'
];
client = {
jasmine: {
random: false
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So Jasmine 3 executes tests in random order by default and since this particular spec relies on the tests being executed sequentially I have disabled the random execution feature.

@johnjbarton johnjbarton merged commit 7f40349 into karma-runner:master May 17, 2019
@devoto13 devoto13 deleted the cleanup-dependencies branch May 18, 2019 00:06
This was referenced Jan 8, 2021
Open
Open
This was referenced May 27, 2021
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnjbarton johnjbarton johnjbarton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devoto13 @johnjbarton