Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: run build on post-install instead of pre-publish #2886

Closed

Conversation

EzraBrooks
Copy link
Collaborator

Fixes #2884.

Switching the bundling to happen on the client-side makes Karma development more flexible. For instance, on projects at work we pull npm packages based on git tags, since we don't have enough to warrant running a private npm registry. If we were to fork Karma, it wouldn't work at all due to the bundling being done on pre-publish.

Additionally, it allows developers to easily pull in pre-release versions of Karma to test locally, since they won't have to manually run the build script when installing the module into a test package.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@EzraBrooks
Copy link
Collaborator Author

I signed it.

@googlebot
Copy link

CLAs look good, thanks!

@EzraBrooks
Copy link
Collaborator Author

Worth noting that I think maybe a more elegant solution would be to compile the client-side resources when Karma spawns the web server for the first time, but this was the easier and quicker way to get my project working again.

@dignifiedquire
Copy link
Member

In the past postinstall steps have been very problematic with npm unfortunately, so I always try and avoid them. Not being able to use master out of the box is not great I agree. Doing the browserify run on first start and then caching the results would be the best way to go I think.

@EzraBrooks
Copy link
Collaborator Author

Okay, I’ll close this PR and work on solving it that way instead.

@EzraBrooks EzraBrooks closed this Nov 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants