fix(preprocessor): retry if fs.readFile fails #2714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dignifiedquire
requested changes
May 28, 2017
lib/preprocessor.js
Outdated
| @@ -121,7 +130,8 @@ var createPreprocessor = function (config, basePath, injector) { | |||
|
|
|||
| nextPreprocessor(null, thisFileIsBinary ? buffer : buffer.toString()) | |||
| }) | |||
| }) | |||
| } | |||
| return fs.readFile(file.originalPath, handleFile) | |||
There was a problem hiding this comment.
This should call handleFile probably?
There was a problem hiding this comment.
fs.readFile is the correct call as handleFile was the original anonymous callback at line 79
I've renamed handleFile to readFileCallback to make it clearer
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When saving a file in IDEs like Visual Studio, Atom, a dozen operations including read/write/delete/rename are performed on the file. When aggressive antivirus like McAfee is running it could make it even worse, there are nearly 50% chance karma will crash because the file is locked
There were multiple issues raised because of this
#1397
#1213
#959
The solution is retry reading file if fs.readFile fails and throw after 3 failed retries