Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependencies #2689

Merged
merged 1 commit into from
Jun 26, 2017
Merged

Conversation

wesleycho
Copy link
Member

@wesleycho wesleycho commented May 6, 2017

  • Update dependencies as part of process to drop support for versions of Node.js below 4

Closes #1812
Closes #2688

@wesleycho wesleycho force-pushed the chore/deps branch 2 times, most recently from 3135864 to 7791970 Compare May 6, 2017 12:06
@wesleycho
Copy link
Member Author

wesleycho commented May 6, 2017

I had to make a couple of changes for the upgrade.

The sinon changes were because sinon deprecated the fake call api from within stub.
The eslint package additions were caused by the upgrade of the eslint standard plugin, which required those packages to have to be installed in order to lint - those also resulted in having to make the minor linting change adjustments.
file-list.spec.js has a few hacky changes to defer checking until after the _.defer calls are able to do their job inside file-list.js.

There is still one test that eludes me currently.

@wesleycho
Copy link
Member Author

This PR passes all CI checks except for Node 0.10 and 0.12 - it requires #2692 in order to properly pass.

@dignifiedquire
Copy link
Member

Before we can merge & publish this, the following needs to happen

@wesleycho wesleycho force-pushed the chore/deps branch 2 times, most recently from 0bfef82 to d9159b1 Compare May 28, 2017 22:48
@wesleycho
Copy link
Member Author

I just went through every repository - I believe we should be good, but you may want to do a second pass.

I also removed lodash from being exported.

- Update dependencies as part of process to drop support for versions of Node.js below 4

Closes karma-runner#1812
Closes karma-runner#2688
@dignifiedquire dignifiedquire merged commit 483bedd into karma-runner:master Jun 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants