Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fail on launcher-, reporter-, plugin-, or preprocessor-load err… #1948

Closed

Conversation

srawlins
Copy link
Contributor

…ors.

Stop karma if a launcher, reporter, plugin, or preprocessor fails to
load, after attempting to load each of them, and reporting errors for
each load error.

Closes #855

…ors.

Stop karma if a launcher, reporter, plugin, or preprocessor fails to
load, after attempting to load each of them, and reporting errors for
each load error.

Closes karma-runner#855
@srawlins
Copy link
Contributor Author

I'm not sure how the authorship worked out... but I grabbed budde377@cd24d95 (authored by me?) and amended with the correct address that Google likes for the CLA. Thanks for the help, @budde377 !!!

@dignifiedquire
Copy link
Member

Thanks @srawlins @budde377 will review tomorrow :)

@budde377
Copy link
Member

budde377 commented Mar 1, 2016

Don't know how pedantic we need to be wrt. authorship, but after the amend, my name has been removed from the commit (and it now says @srawlins committed by @srawlins). So for the sake of accountability, shouldn't it somehow be evident that the commit is joint work?

@srawlins
Copy link
Contributor Author

srawlins commented Mar 1, 2016

Agreed, if you'd like to take the PR again, Christian, feel free. This
commit has my correct email attached, so if you make a PR again, it should
pass the CLA bot.
On Feb 29, 2016 9:58 PM, "Christian Budde Christensen" <
[email protected]> wrote:

Don't know how pedantic we need to be wrt. authorship, but after the
amend, my name has been removed from the commit (and it now says @srawlins
https://github.com/srawlins committed by @srawlins
https://github.com/srawlins). So for the sake of accountability,
shouldn't it somehow be evident that the commit is joint work?


Reply to this email directly or view it on GitHub
#1948 (comment).

@budde377
Copy link
Member

budde377 commented Mar 1, 2016

I have successfully done this in #1931.

@dignifiedquire
Copy link
Member

Closing in favor of #1931

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants