fix(karma): Fix issue regarding escape quotes #1938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, can you squash the two commits into one please? |
…er#1876. fix(karma): Escape quotes for file names. This fixes issue karma-runner#1876.
Moumi
force-pushed
the
fix-issue-escape-single-quotes
branch
from
9fa540d
to
9dff3f3
Compare
|
@dignifiedquire I have squashed them together. Never done it before, so I hope it all went well. 😉 |
|
Thanks |
looks good.
dignifiedquire
added a commit
that referenced
this pull request
Feb 29, 2016
…otes fix(karma): Fix issue regarding escape quotes
|
Also this should probably use JSON.stringify() instead of hand rolled replace() calls. Files with newlines in them will also cause problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change a line to escape single quote characters in filenames.
Closes #1876