fix(runner): Remove null characters from terminal output #1839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the null characters from the output printed by not replacing the "tail" with `\x00`. An buffer slice is returned when necessary. Closes karma-runner#1343
|
What is the exact difference for the user from doing this/what exactly is fixed here? |
|
Basically this fixes the issue: #1343, where a user reported that the |
|
@budde377 thanks, just saw you mentioned it in the commit message -.- |
dignifiedquire
added a commit
that referenced
this pull request
Jan 28, 2016
…-from-terminal-output fix(runner): Remove null characters from terminal output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This slices the buffer rather than modifying it. The buffer slice is returned, with the exit code, as an object: