Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Switch all requires from fs to graceful-fs #1807

Merged

Conversation

testower
Copy link
Contributor

Took the liberty to provide a fix here. I'm still hitting EMFILE in certain situations. Could it be due to launchers? I can definitely run my tests with a much lower ulimit -n now though.

Partially fixes #544

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@testower
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@dignifiedquire
Copy link
Member

Thanks a lot :octocat:

dignifiedquire added a commit that referenced this pull request Jan 19, 2016
fix: Switch all requires from fs to graceful-fs
@dignifiedquire dignifiedquire merged commit ecd8546 into karma-runner:master Jan 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure to not hit open file descriptor limit
3 participants