You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently the preprocessor functionality is not resilient to a large number of files... At the small number of 256 you will reach the Mountain Lion limit... The solution to this is to implement a buffer that queues requests beyond a particular limit and flushes them accordingly. @isaacs has an implementation of this as a drop in replacement for fs called node-graceful-fs. The tests do not pass when we drop this in however, I think because karma is mocking fs.
From my perspective we have two options...
We can either update the tests fs mocking to not collide with node-graceful-fs, not really sure how to do this currently, the problem is still unclear to me.
We can implement our own queue system inside of preprocessor for read's only.
Please let me know which approach you want to take and I will look into implementing it. Currently our project can't use preprocessing because of this limitation.
(I don't consider calling ulimit as a viable solution.)
The text was updated successfully, but these errors were encountered:
I know about this issue and yep, it has to be fixed asap. I need to look into it more, there are multiple things how to improve it. Using graceful-fs is probably the first thing we should do...
Currently the preprocessor functionality is not resilient to a large number of files... At the small number of 256 you will reach the Mountain Lion limit... The solution to this is to implement a buffer that queues requests beyond a particular limit and flushes them accordingly. @isaacs has an implementation of this as a drop in replacement for
fs
called node-graceful-fs. The tests do not pass when we drop this in however, I think because karma is mockingfs
.From my perspective we have two options...
fs
mocking to not collide with node-graceful-fs, not really sure how to do this currently, the problem is still unclear to me.Please let me know which approach you want to take and I will look into implementing it. Currently our project can't use preprocessing because of this limitation.
(I don't consider calling ulimit as a viable solution.)
The text was updated successfully, but these errors were encountered: