-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Karma has a non-dev dependency on chromium (via the puppeteer package) #3191
Closed
davidshepherd7 opened this issue
Oct 22, 2018
· 2 comments
· Fixed by JetBrains/ring-ui#463, Narshe1412/nuarca-sql#25 or karronoli/redpen#10
Closed
Karma has a non-dev dependency on chromium (via the puppeteer package) #3191
davidshepherd7 opened this issue
Oct 22, 2018
· 2 comments
· Fixed by JetBrains/ring-ui#463, Narshe1412/nuarca-sql#25 or karronoli/redpen#10
Comments
davidshepherd7
added a commit
to davidshepherd7/karma
that referenced
this issue
Oct 22, 2018
I am also getting failures on all my builds after doing
Is this relevant?
downgrading to npm install -g [email protected] seems to work |
puppeteer also takes 303 Mb of disk space which equals to the "weight" of all other packages in my setup (Angular 7 app). It's very annoying |
johnjbarton
added a commit
that referenced
this issue
Oct 22, 2018
Fixes #3191 Thanks to @davidshepherd7 for suggesting this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This commit added puppeteer (which is a wrapper around headless chrome) as a non-dev dependency of karma. Previously karma had phantomjs-prebuilt as a dev dependency.
Presumably this change was unintentional? It's a bit annoying because it makes the install of karma take a long time.
Expected behaviour
Installing karma does not install any particular browser.
Actual behaviour
Installing karma installs chromium.
Environment Details
karma --version
): Karma version: 3.1.0karma.config.js
file: N/ASteps to reproduce the behaviour
The text was updated successfully, but these errors were encountered: