Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Karma auto install socket.io 1.4.8 it makes ie9 can not run karma test. #2190

Closed
chenbojian opened this issue Jun 24, 2016 · 4 comments
Closed

Karma auto install socket.io 1.4.8 it makes ie9 can not run karma test. #2190

chenbojian opened this issue Jun 24, 2016 · 4 comments
Labels
help wanted type: bug

Comments

@chenbojian
Copy link

Expected behavior

can run karma test in IE9

Actual behavior

can not run karma test in IE9. only if I lock socket.io version to 1.4.6, it can work.

Enviroment Details

  • Karma version (output of karma --version):
    0.13.19
  • Relevant part of your karma.config.js file

Steps to reproduce the behaviour
@shirish87
Copy link

Reason for this is the use of Uint8Array in the 1.4.8 release of socket.io-client, which isn't natively supported in IE9.

shirish87 added a commit to shirish87/karma that referenced this issue Jun 25, 2016
@shirish87
fix(client): Locks socket.io dependency to 1.4.6
c6c9c37 
socket.io-client v1.4.7 introduced changes that made it incompatible with IE9.

Fixes karma-runner#2190
@dignifiedquire
Copy link
Member

Yes #2188 shows that these failures happen. Looks like we need to add a shim for Uint8Array now

@dignifiedquire
Copy link
Member

Ref socketio/engine.io#407

@hpurmann hpurmann mentioned this issue Jun 29, 2016
Closed
@wcjohnson11 wcjohnson11 mentioned this issue Aug 15, 2016
Merged
@vedharish
Copy link

Using this as a polyfill for socket-io 1.4.8 for IE9 seems to work

@wesleycho wesleycho mentioned this issue Dec 6, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@shirish87 @dignifiedquire @vedharish @chenbojian