-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Karma chrashes with: Fatal error: Wrong length [0.13.16 regression] #1768
Comments
the same with Firefox on Mac OS:
|
It's probably because of upgrading |
|
In Firefox 31.0.0 on Linux (Travis CI) also. |
I got a same error with Karma 0.13.16 . Does this caused by #1765 ? |
@falsandtru see my comment above. This is fixed by #1765 because by ES6 |
@zloirock thanks for your response. Excuse me, how can we solve this problem? Won't fix? |
@falsandtru rather it's not
I can't reproduce it. Most likely to |
It error seems caused by coverage processing. reporters: ['dots', 'coverage'],
preprocessors: {
'dist/*.js': ['coverage']
}, It error also caused on Firefox and Chrome. Not only IE. Windows7 x64 latest |
@falsandtru do you have a repo I can test with? |
@falsandtru right you are! Crash only happens when coverage reporter is set. @dignifiedquire you can test my repo: https://github.com/egoroof/browser-id3-writer |
@egoroof yeah, |
I got the same error too. Crash only happens when I enable coverage report |
This should address the problem detailed here: karma-runner/karma#1768
- Switch to Chrome (Phantomjs failed on Audio test) - Downgrage to karma 0.13.15 (karma-runner/karma#1768) - Add Foundation for testing + Use teaspoon for a jQuery-like DOM selector, stateless components wrapper - Tested: + ControlButtons + AudioPlayer (need more love)
`Buffer` inherits from `Uint8Arry` so the constructor needs to be called with integers and mustn't be called with floats. This patch ensures that the result of the the calculation in the `shrinkStrategy` in `Receiver` returns an integer. The reason why this has not been a problem up to now is that a there is a [V8 Bug](https://code.google.com/p/v8/issues/detail?id=4552) that the [spec](http://tc39.github.io/ecma262/#sec-typedarray-length) is not adhered in this case. This is a blocking issue for [Karma](karma-runner/karma#1768) as the upgrade to [[email protected]](https://github.com/zloirock/core-js) now enforces this error.
Filed a PR to |
@dignifiedquire thanks! |
- Switch to Chrome (Phantomjs failed on Audio test) - Downgrage to karma 0.13.15 (karma-runner/karma#1768) - Add Foundation for testing + Use teaspoon for a jQuery-like DOM selector, stateless components wrapper - Tested: + ControlButtons + AudioPlayer (need more love)
- Switch to Chrome (Phantomjs failed on Audio test) - Downgrage to karma 0.13.15 (karma-runner/karma#1768) - Add Foundation for testing + Use teaspoon for a jQuery-like DOM selector, stateless components wrapper - Tested: + ControlButtons + AudioPlayer (need more love)
- Switch to Chrome (Phantomjs failed on Audio test) - Downgrage to karma 0.13.15 (karma-runner/karma#1768) - Add Foundation for testing + Use teaspoon for a jQuery-like DOM selector, stateless components wrapper - Tested: + ControlButtons + AudioPlayer (need more love)
Also seeing problems.... have to revert to older version of karma unfortunately |
@dignifiedquire's PR is already merged, so now we need to wait for a quick release. |
+1. I have the same problem https://travis-ci.org/codenautas/tedede/jobs/99987514 but only in travis (not in windows) |
…wrapper - bug in `ws` module karma-runner/karma#1768 websockets/ws#645
Because it creates too many problems for you, I have temporarily removed |
@zloirock thanks a lot! and sorry for all the issues, I will push a release with that version in the morning. |
Should be fixed in |
@dignifiedquire thanks! It is fixed. |
Thanks @dignifiedquire for the quick turnaround! |
Mark says that karma-runner/karma#1768 is resolved in 0.13.17
Mark says that karma-runner/karma#1768 is resolved in 0.13.17 Please enter the commit message for your changes. Lines starting
Mark says that karma-runner/karma#1768 is resolved in 0.13.17 Please enter the commit message for your changes. Lines starting
Mark says that karma-runner/karma#1768 is resolved in 0.13.17
`Buffer` inherits from `Uint8Arry` so the constructor needs to be called with integers and mustn't be called with floats. This patch ensures that the result of the the calculation in the `shrinkStrategy` in `Receiver` returns an integer. The reason why this has not been a problem up to now is that a there is a [V8 Bug](https://code.google.com/p/v8/issues/detail?id=4552) that the [spec](http://tc39.github.io/ecma262/#sec-typedarray-length) is not adhered in this case. This is a blocking issue for [Karma](karma-runner/karma#1768) as the upgrade to [[email protected]](https://github.com/zloirock/core-js) now enforces this error.
Mark says that karma-runner/karma#1768 is resolved in 0.13.17
Mark says that karma-runner/karma#1768 is resolved in 0.13.17
Mark says that karma-runner/karma#1768 is resolved in 0.13.17
I've just updated from 0.13.15 where everything was fine to 0.13.16 and run tests. Karma has crashed with IE runner (with chrome and firefox there are no problems):
The text was updated successfully, but these errors were encountered: