Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Karma 0.13.9 doesn't work with IE<9 #1564

Closed
mgol opened this issue Aug 17, 2015 · 6 comments
Closed

Karma 0.13.9 doesn't work with IE<9 #1564

mgol opened this issue Aug 17, 2015 · 6 comments
Assignees
@dignifiedquire
Labels
priority: high type: bug

Comments

@mgol
Copy link
Contributor

mgol commented Aug 17, 2015

With Karma 0.13.9 IE<9 no longer get captured. I didn't have such problems with Karma 0.12.24.

To see the problems, first make sure you have BROWSER_STACK_USERNAME & BROWSER_STACK_ACCESS_KEY environmental variables set up properly to your BrowserStack account data. Then checkout Sizzle's commit jquery/sizzle@c76829c and run:

npm install
npm test

You'll see that at least the karma:desktop, karma:ios & karma:oldIe targets work fine (you can kill the process afterwards, the rest doesn't matter here.

Then change Karma to 0.13.9 & grunt-karma to 0.8.3 (or checkout the ie-doesnt-work branch from my fork where it's set up this way) and run:

npm install
npm test

again. karma:desktop &, karma:ios should pass again but you'll then see:

Running "karma:oldIe" (karma) task
17 08 2015 23:55:19.484:INFO [karma]: Karma v0.13.9 server started at http://localhost:9876/
17 08 2015 23:55:19.489:INFO [launcher]: Starting browser ie 6.0 (Windows XP) on BrowserStack
17 08 2015 23:55:19.490:INFO [launcher]: Starting browser ie 7.0 (Windows XP) on BrowserStack
17 08 2015 23:55:19.490:INFO [launcher]: Starting browser ie 8.0 (Windows 7) on BrowserStack
17 08 2015 23:55:25.506:INFO [launcher.browserstack]: ie 7.0 (Windows XP) session at https://www.browserstack.com/automate/builds/57633abc95c7d50511cefe33bf53e74df4876acd/sessions/d70ac260f01ccc86b980977a05ba22813327476f
17 08 2015 23:55:25.532:INFO [launcher.browserstack]: ie 6.0 (Windows XP) session at https://www.browserstack.com/automate/builds/57633abc95c7d50511cefe33bf53e74df4876acd/sessions/bc7eaf843242d0de1788f852a84684c1a6a12c3d
17 08 2015 23:55:25.716:INFO [launcher.browserstack]: ie 8.0 (Windows 7) session at https://www.browserstack.com/automate/builds/57633abc95c7d50511cefe33bf53e74df4876acd/sessions/643f6e191bde5edaeaf369dd566f1dd3250431b7
18 08 2015 00:00:30.112:WARN [launcher.browserstack]: ie 7.0 (Windows XP) has not captured in 300000 ms, killing.
18 08 2015 00:00:33.131:WARN [launcher.browserstack]: ie 6.0 (Windows XP) has not captured in 300000 ms, killing.
18 08 2015 00:00:33.505:INFO [launcher.browserstack]: ie 7.0 (Windows XP) session at https://www.browserstack.com/automate/builds/57633abc95c7d50511cefe33bf53e74df4876acd/sessions/1274e6da370de9848a9d1af9b95ac3e72468db58
18 08 2015 00:00:34.915:WARN [launcher.browserstack]: ie 8.0 (Windows 7) has not captured in 300000 ms, killing.
18 08 2015 00:00:36.211:INFO [launcher.browserstack]: ie 6.0 (Windows XP) session at https://www.browserstack.com/automate/builds/57633abc95c7d50511cefe33bf53e74df4876acd/sessions/04cf53654c029951bacf73dc68d7ca684912dd52
18 08 2015 00:00:37.998:INFO [launcher.browserstack]: ie 8.0 (Windows 7) session at https://www.browserstack.com/automate/builds/57633abc95c7d50511cefe33bf53e74df4876acd/sessions/d036746d059fd40ffb80e2d57a8855f94fc000f0

and so on - until everything times out and the process is killed.

EDIT: Added info about setting up BrowserStack environmental variables.
This was referenced Aug 17, 2015
Closed
Open
@dignifiedquire
Copy link
Member

Thanks for the detailed report, will look into it as soon as I find some time

@dignifiedquire
Copy link
Member

I've contacted browser stack for a proper account so I can setup tests on travis to ensure we do not miss this again, and I can test this properly and fix

@dignifiedquire dignifiedquire mentioned this issue Sep 9, 2015
Closed
@dignifiedquire
Copy link
Member

I've started working on this, but I'm not able to connect to IE6 for some reason. @mgol do you have any idea what could be going wrong?

This was referenced Jan 19, 2016
Closed
Closed
@dignifiedquire dignifiedquire self-assigned this Jan 19, 2016
@dignifiedquire
Copy link
Member

@JamesMGreene if you have any ideas for IE6 help I'd appreciate it as well.

WIP PR is up at #1813

andersonba added a commit to andersonba/whoami.js that referenced this issue Jan 27, 2016
@andersonba
Downgrade karma version (fix ie9 capture)
10db6b6 
See more: karma-runner/karma#1564
@andersonba
Copy link

27 01 2016 17:12:04.955:WARN [launcher.browserstack]: ie 9.0 (Windows 7) has not captured in 90000 ms, killing.

andersonba added a commit to andersonba/whoami.js that referenced this issue Jan 27, 2016
@andersonba
Downgrade karma version (fix ie9 capture)
ba03009 
See more: karma-runner/karma#1564
andersonba added a commit to andersonba/whoami.js that referenced this issue Jan 27, 2016
@andersonba
Downgrade karma version (fix ie9 capture)
d0f1b1d 
See more: karma-runner/karma#1564

Also, disable temporarily ie9
Also, test chrome/firefox on mac
@dignifiedquire
Copy link
Member

Released 0.13.20 which supports forceJSONP and now should work with IE >= 7

wmfgerrit pushed a commit to wikimedia/oojs-core that referenced this issue Feb 12, 2016
@Krinkle
build: Bump devDependencies and fine-tune Kama config
6ee7673 
Follows-up 16a5f8c which downgraded Karma back to 0.12.
The issue with IE<9 was fixed in Karma v0.13.20.

* karma-runner/karma#983
* karma-runner/karma#1564

Also makes use of the new 'concurrency' option introduced in
Karma v0.13.12. This makes the test run a bit faster by starting
browser #4 as soon as one of browsers 1-2-3 is finished, etc.

Once we drop ES3 and IE6 support, we can remove ci1/ci2 split.

Also:
* PhantomJS node-wrapper package got renamed, which is
  required by karma-phantomjs-launcher.
* Can't upgrade grunt-contrib-uglify because the new version
  depends on a newer version of npm package 'gzip-size' which
  dropped support for Node 0.10 (which Wikimedia CI still uses).

Change-Id: I08bed822273bca2d2d80fa765fc0b0fbba4d997a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dignifiedquire dignifiedquire

Labels
priority: high type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] Add tests and support for IE6-9 dignifiedquire/karma
3 participants
@dignifiedquire @andersonba @mgol