Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Runner race condition of stale files on subsequent runs #1550

Closed
thetrevdev opened this issue Aug 7, 2015 · 0 comments · Fixed by #1551 · May be fixed by Omrisnyk/npm-lockfiles#122 or Omrisnyk/npm-lockfiles#132
Closed

Runner race condition of stale files on subsequent runs #1550

thetrevdev opened this issue Aug 7, 2015 · 0 comments · Fixed by #1551 · May be fixed by Omrisnyk/npm-lockfiles#122 or Omrisnyk/npm-lockfiles#132
Labels
PR exists type: bug

Comments

@thetrevdev
Copy link
Contributor

Noticed behavior:
using karma start and karma run, multiple executions of karma run results in seeing stale files / results.

This is because the web-server gets the file-list from the last file_list_modified event. Runner test execution is scheduled after file-list refresh resolves. This results in a race condition because the event is now emitted late because of a newly introduced trailing throttle.
thetrevdev pushed a commit to thetrevdev/karma that referenced this issue Aug 7, 2015
fix(file-list): refresh resolves before 'file_list_modified' event
afa96b1 
change emitModified to emit 'file_list_modified' immediately
during refresh() to remove throttle and race condition during
subsequent runner executions

Closes karma-runner#1550
@thetrevdev thetrevdev mentioned this issue Aug 7, 2015
Merged
thetrevdev pushed a commit to thetrevdev/karma that referenced this issue Aug 7, 2015
fix(file-list): refresh resolves before 'file_list_modified' event
0be73c0 
change emitModified to emit 'file_list_modified' immediately
during refresh() to remove throttle and race condition during
subsequent runner executions

Closes karma-runner#1550
thetrevdev pushed a commit to thetrevdev/karma that referenced this issue Aug 8, 2015
fix(file-list): refresh resolves before 'file_list_modified' event
ce08f06 
change emitModified to emit 'file_list_modified' immediately
during refresh() to remove throttle and race condition during
subsequent runner executions

Closes karma-runner#1550
thetrevdev pushed a commit to thetrevdev/karma that referenced this issue Aug 9, 2015
fix(file-list): refresh resolves before 'file_list_modified' event
fe195d7 
change emitModified to emit 'file_list_modified' immediately
during refresh() to remove throttle and race condition during
subsequent runner executions

Closes karma-runner#1550
thetrevdev pushed a commit to thetrevdev/karma that referenced this issue Aug 9, 2015
fix(file-list): refresh resolves before 'file_list_modified' event
65f1eca 
change emitModified to emit 'file_list_modified' immediately
during refresh() to remove throttle and race condition during
subsequent runner executions

Closes karma-runner#1550
@Omrisnyk Omrisnyk mentioned this issue Oct 27, 2023
Open
@Omrisnyk Omrisnyk mentioned this issue Dec 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
PR exists type: bug
Projects
None yet
Milestone
No milestone
2 participants
@dignifiedquire @thetrevdev