Skip to content

Commit

Permalink
feat(grunt): run check_clean before starting release. (#2978)
Browse files Browse the repository at this point in the history
* fix(package.json): sinon-chai 2.13 is not compatible with sinon 4.x

* feat(grunt): run check_clean before starting release.

By checking early we avoid pushing a new version to github that is not then published to npm.
  • Loading branch information
johnjbarton authored Apr 23, 2018
1 parent 0b2c690 commit a3ff6c8
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
2 changes: 2 additions & 0 deletions gruntfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,7 @@ module.exports = function (grunt) {
}
})

grunt.loadNpmTasks('grunt-check-clean')
grunt.loadTasks('tasks')
require('load-grunt-tasks')(grunt)

Expand All @@ -141,6 +142,7 @@ module.exports = function (grunt) {

grunt.registerTask('release', 'Build, bump and publish to NPM.', function (type) {
grunt.task.run([
'check_clean',
'npm-contributors',
'bump:' + (type || 'patch') + ':bump-only',
'build',
Expand Down
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -397,6 +397,7 @@
"grunt-browserify": "^5.0.0",
"grunt-bump": "^0.8.0",
"grunt-cli": "^1.1.0",
"grunt-check-clean": "^0.1.2",
"grunt-contrib-watch": "^1.0.0",
"grunt-conventional-changelog": "^6.0.1",
"grunt-conventional-github-releaser": "^1.0.0",
Expand Down

0 comments on commit a3ff6c8

Please sign in to comment.