fix(init): to not give false warning about missing requirejs

karma-runner · Apr 4, 2013 · 562607a · 562607a
1 parent bf59278
commit 562607a
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 3 deletions.
diff --git a/lib/init.js b/lib/init.js
@@ -177,17 +177,21 @@ var StateMachine = function(rli) {
         }
       }
 
-      if (line && currentQuestion.validate) {
-        currentQuestion.validate(line);
+      if (line === '') {
+        line = null;
       }
 
       if (currentQuestion.boolean) {
         line = (line === 'yes' || line === 'true' || line === 'on');
       }
 
+      if (line !== null && currentQuestion.validate) {
+        currentQuestion.validate(line);
+      }
+
       if (currentQuestion.multiple) {
         answers[pendingQuestionId] = answers[pendingQuestionId] || [];
-        if (line) {
+        if (line !== null) {
           answers[pendingQuestionId].push(line);
           rli.prompt();
 

diff --git a/test/unit/init.spec.coffee b/test/unit/init.spec.coffee
@@ -121,6 +121,22 @@ describe 'init', ->
       expect(done).to.have.been.called
 
 
+    it 'should parse booleans before validation', ->
+      validator = sinon.spy (value) ->
+        expect(typeof value).to.equal 'boolean'
+
+      questions = [
+        {id: 'what', options: ['yes', 'no'], boolean: true, validate: validator}
+        {id: 'really', options: ['yes', 'no'], boolean: true, validate: validator}
+      ]
+
+      machine.process questions, done
+      machine.onLine 'yes'
+      machine.onLine 'no'
+
+      expect(validator).to.have.been.calledTwice
+
+
   describe 'getBasePath', ->
 
     # just for windows.