fix(config): ensure basePath is always resolved

karma-runner · Apr 2, 2013 · 2e5c5aa · 2e5c5aa
1 parent 39f9d66
commit 2e5c5aa
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/lib/config.js b/lib/config.js
@@ -243,6 +243,9 @@ var parseConfig = function(configFilePath, cliOptions) {
     // always ignore the config file itself
     config.exclude.push(configFilePath);
   }
+  else {
+    config.basePath = path.resolve(config.basePath);
+  }
 
   return normalizeConfig(config);
 };

diff --git a/test/unit/config.spec.coffee b/test/unit/config.spec.coffee
@@ -235,6 +235,12 @@ describe 'config', ->
       expect(config.basePath).to.equal resolveWinPath('/some') # overriden by CLI
       expect(config.urlRoot).to.equal '/' # default value
 
+    it 'should not read config file, when null but still resolve cli basePath', ->
+      config = e.parseConfig null, {basePath: './some' }
+
+      expect(logSpy).not.to.have.been.called
+      expect(config.basePath).to.equal resolveWinPath('./some')
+      expect(config.urlRoot).to.equal '/' # default value
 
   describe 'normalizeConfig', ->