Add timeout before starting qunit #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this the right approach, though?
PS. would it be possible for the tests to cover this case?
…On Tue, Apr 17, 2018 at 11:57 AM Johann-S ***@***.***> wrote:
In this PR QUnit removed their timeout : qunitjs/qunit#1246
<qunitjs/qunit#1246> so we try to run unit tests
before they are loaded, that leads to error like No tests were run.
Related to #103 <#103>
/CC @XhmikosR <https://github.com/XhmikosR> @dignifiedquire
<https://github.com/dignifiedquire>
------------------------------
You can view, comment on, or merge this pull request online at:
#107
Commit Summary
- Add timeout before starting qunit
File Changes
- *M* src/adapter.js
<https://github.com/karma-runner/karma-qunit/pull/107/files#diff-0>
(5)
Patch Links:
- https://github.com/karma-runner/karma-qunit/pull/107.patch
- https://github.com/karma-runner/karma-qunit/pull/107.diff
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#107>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAVVtf8sMjFka8UxGW0RtdXMFnTwVYg0ks5tpa6CgaJpZM4TX5gH>
.
|
|
It was the approach used by QUnit, and with that delay our tests can run, I updated my commit and tests passed |
|
Yes, I understand that :)
What I'm saying is that since they removed the delay, something else must
change here to comply with that.
PS. with tests I meant the tests in this repo which didn't catch this case
since they have been always green.
…On Tue, Apr 17, 2018 at 12:12 PM Johann-S ***@***.***> wrote:
It was the approach used by QUnit, and with that delay our tests can run,
I updated my commit and tests passed
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#107 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAVVtRpax5hC2wA-3-lvFCunxf_qhIl5ks5tpbH4gaJpZM4TX5gH>
.
|
|
Nope, the other changes must be in our unit tests but not here, because it's in the internal logic of QUnit not in the public API. They were green because we tested with just one file, so it's pretty hard to test that, plus in our use case we load files from CDN EDIT: ping @dignifiedquire |
|
Ping @dignifiedquire |
|
I added a unit test which reproduce this use case |
|
What are you npm usernames and I can add you for karma-qunit (although I
think johnjbarton is in the process pushing to npm right now)...
…On Wed, May 2, 2018 at 3:05 PM, XhmikosR ***@***.***> wrote:
@Johann-S <https://github.com/Johann-S>: do you have access to the npm
account too? If not maybe ask @zzo <https://github.com/zzo> ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#107 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAr0Gu0ehvG4zGdlvb3Ws7kIY9tBEbqDks5tui2egaJpZM4TX5gH>
.
|
|
@zzo my username is Thank you 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR QUnit removed their timeout : qunitjs/qunit#1246 so we try to run unit tests before they are loaded, that leads to error like
No tests were run.Fixes: #103
/CC @XhmikosR @dignifiedquire