Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Absolute outputFile path #84

Merged
merged 1 commit into from
Mar 3, 2016
Merged

Handle Absolute outputFile path #84

merged 1 commit into from
Mar 3, 2016

Conversation

vermeeca
Copy link
Contributor

@vermeeca vermeeca commented Mar 1, 2016

On my machine (Windows 10, nodejs 4.2.3) the Karma Junit reporter was failing with errors like the following:

WARN [reporter.junit]: Cannot write JUnit xml ENOENT: no such file or directory, open 'c:\code\myproject\src\myproject.Web\PhantomJS_1.9.8_(Windows_8)\c:\code\myproject\src\myproject.Web\test-results.xml'

So, outputFile was coming into the Karma Junit reporter as an absolute path instead of a relative, or even just a file name.

The code changes in this PR fixed the issue for me.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@vermeeca
Copy link
Contributor Author

vermeeca commented Mar 1, 2016

CLA is signed. I'll go in and fix those eslint issues showing up in the travis build

@googlebot
Copy link

CLAs look good, thanks!

@dignifiedquire
Copy link
Member

Thanks, can you please squash your commits and change the commit message according to our convention

Modifies the Junit Reporter so that it doesn't try to combine the output directory path and the output file, if the output file is already an absolute path

Closes #83
@vermeeca
Copy link
Contributor Author

vermeeca commented Mar 3, 2016

OK, done. LMK if I missed anything.

@dignifiedquire
Copy link
Member

Thanks :octocat:

dignifiedquire added a commit that referenced this pull request Mar 3, 2016
@dignifiedquire dignifiedquire merged commit 8cd1730 into karma-runner:master Mar 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants