fix: escape filesystem characters in browser name #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Met48
force-pushed
the
fix-filenames
branch
2 times, most recently
from
a4bfa0d
to
8ab92d0
Compare
|
Updated replacement parameter |
|
great please update the PR title to match our conventions |
Met48
changed the title
|
Thanks, can you please rebase onto master, there are some merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into an issue when using JSDom as a browser, since its name contains
:. This diff uses sanitizie-filename to escape the browser name, which will guard against this and other invalid filenames.