Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small typo in README #142

Merged
merged 1 commit into from
Jan 8, 2019
Merged

Conversation

csuarez
Copy link
Contributor

@csuarez csuarez commented May 4, 2017

Just a missing comma in the configuration example.

Just a missing comma in the configuration example.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@csuarez
Copy link
Contributor Author

csuarez commented May 4, 2017

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@hicom150
Copy link
Collaborator

hicom150 commented Jan 8, 2019

Looks good to me 👍
@johnjbarton would be convenient to merge this PR?

@johnjbarton
Copy link
Contributor

@johnjbarton would be convenient to merge this PR?

I think you should press "Squash and merge"

@joeyparrish joeyparrish merged commit 952cf26 into karma-runner:master Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants