Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow name and classname generation override #75

Closed
mleonh opened this issue Dec 9, 2015 · 1 comment
Closed

Allow name and classname generation override #75

mleonh opened this issue Dec 9, 2015 · 1 comment

Comments

@mleonh
Copy link
Contributor

mleonh commented Dec 9, 2015

Looking at issues such as #62 and #69, it certainly seems like different users of this plugin have different needs concerning how the testcase attributes 'name' and 'classname' are generated. In our case, a recent change introduced in e4f7ebd is pretty much the exact opposite of what we need.

It should be easy to allow users to add functions to their configs to handle this – in other words, for the 'classname' attribute we'd allow overriding the 'getClassName' function, and add something similar for 'name'.

Would you accept a PR for this if I implement it?

@mleonh mleonh changed the title Allow name and classname generation overide Allow name and classname generation override Dec 9, 2015
@irfanraza
Copy link

I agree with @mleonh
We had a requirement to generate different classname but this was not possible with this reporter. Finally I had to process the xml report again to make it acceptable(for SonarQube).

mleonh pushed a commit to mleonh/karma-junit-reporter that referenced this issue Dec 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants