Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapter.js: Include full name of spec in specDone() #198

Merged
merged 1 commit into from
Apr 9, 2018

Conversation

kyliau
Copy link
Collaborator

@kyliau kyliau commented Mar 12, 2018

This commit appends the field 'fullName' to the result sent back to the
Karma server. The full name is useful to identify the exact spec that
was run.

API for specResult: https://jasmine.github.io/api/2.9/global.html#SpecResult

Copy link
Contributor

@johnjbarton johnjbarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@johnjbarton
Copy link
Contributor

I think if you just rebase and repush the travis error will go away.

This commit appends the field 'fullName' to the result sent back to the
Karma server. The full name is useful to identify the exact spec that
was run.

API for specResult: https://jasmine.github.io/api/2.9/global.html#SpecResult
@johnjbarton johnjbarton merged commit 4f70e5e into karma-runner:master Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants