-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.2.5 release broke cobertura reports #91
Comments
Switching to a single reporter seems to work fine:
|
Same here. I don't get the report within the correct folder. |
Also seeing this with multiple coverage reporters. |
Same here. It was working fine for my multiple reports for 0.2.4 when i specified which directory the reports should appear in, now all the reports appear in a coverage directory relative to the base path with 0.2.5 |
Same here. Getting reports, but not in the correct |
Hey guys, thanks for reporting the bug. This regression has been introduced when I refactored the code to support the You can switch back to |
Problem is probably only using variable config for resolveOutput directory on https://github.com/karma-runner/karma-coverage/blob/master/lib/reporter.js#L127. reporterConfig is correct variable. |
The `subdir` option previously introduced in karma-coverage-reporter 0.2.5 brings an issue: it wasn't possible anymore to configure a specific output directory for each reporter. This fix makes it possible again. Fix #91
The `subdir` option previously introduced in karma-coverage-reporter 0.2.5 brings an issue: it wasn't possible anymore to configure a specific output directory for each reporter. This fix makes it possible again. Fix #91
Ok guys it should be fixed on the
|
yes, now it works fine. Thanks for the quick fix |
The `subdir` option previously introduced in karma-coverage 0.2.5 brings an issue: it wasn't possible anymore to configure a specific output directory for each reporter. This fix makes it possible again. Fix #91
The `subdir` option previously introduced in karma-coverage 0.2.5 brings a regression: it wasn't possible anymore to configure a specific output directory/subdirectory for each reporter. This fix makes it possible again. Fix #91
Ok guys, the patch should be soon published on NPM (tag |
Tag doesnt seem to have been pushed? 0.2.6 not shown on github or npm. |
I'll look into it. |
The machine automatically releasing the new versions is currently down. It should be restarted today. Don't hesitate to ping this thread if no NPM pushes happen. |
Still present in 0.2.7. My coverageReporter in karma.config.js looks like this: coverageReporter: {
dir: 'coverage/',
reporters: [
{ type: 'html', subdir: 'report-html' },
{ type: 'text', subdir: '.', file: 'text.txt' },
{ type: 'text-summary', subdir: '.', file: 'text-summary.txt' }
]
}, The reports are generated successfully, but no data is output. |
Never mind. I just realized that if don't specify coverageReporter: {
dir: 'coverage/',
reporters: [
{ type: 'html', subdir: 'report-html' },
{ type: 'text' },
{ type: 'text-summary' }
]
}, Maybe the docs should be more accurate about this, and also sometimes I would like to have the output on both a file and console. |
That's weird, I think your first configuration should work. I will look into it. |
I can confirm that with the update from 0.2.6 to 0.2.7 karma-coverage now ignores the subdir setting. |
Here is my relevant config
Reverting to 0.2.4 fixes the issue.
The text was updated successfully, but these errors were encountered: