fix: update to work with Karma 0.11

Since Karma executes immediately, we don't have all the browsers in advance, the reporter has to listen on browser_start instead. This re-introduces b744d6f but in a back-compatible way.
karma-runner · Nov 29, 2013 · 89c9817 · 89c9817
1 parent 9b78280
commit 89c9817
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 5 deletions.
diff --git a/lib/reporter.js b/lib/reporter.js
@@ -64,10 +64,18 @@ var CoverageReporter = function(rootConfig, helper, logger) {
   }
 
   this.onRunStart = function(browsers) {
-    collectors = {};
-    browsers.forEach(function(browser) {
-      collectors[browser.id] = new istanbul.Collector();
-    });
+    collectors = Object.create(null);
+
+    // TODO(vojta): remove once we don't care about Karma 0.10
+    if (browsers) {
+      browsers.forEach(function(browser) {
+        collectors[browser.id] = new istanbul.Collector();
+      });
+    }
+  };
+
+  this.onBrowserStart = function(browser) {
+    collectors[browser.id] = new istanbul.Collector();
   };
 
   this.onBrowserComplete = function(browser, result) {

diff --git a/test/reporter.spec.coffee b/test/reporter.spec.coffee
@@ -120,7 +120,8 @@ describe 'reporter', ->
       fakeOpera = makeBrowser 'bbb', 'Opera/9.80 Mac OS X Version/12.00', browsers, emitter
       browsers.add fakeChrome
       browsers.add fakeOpera
-      reporter.onRunStart browsers
+      reporter.onRunStart()
+      browsers.forEach (b) -> reporter.onBrowserStart b
       mockFs.writeFile.reset()
       mockMkdir.reset()