marshall.cachew: better exception in case we fail to get type hints f…

…rom type
karlicoss · Oct 19, 2024 · f01317c · f01317c
1 parent bf5ced0
commit f01317c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -68,7 +68,7 @@ jobs:
 
     - uses: actions/setup-python@v5
       with:
-        python-version: '3.8'
+        python-version: '3.10'
 
     - uses: actions/checkout@v4
       with:

diff --git a/src/cachew/marshall/cachew.py b/src/cachew/marshall/cachew.py
@@ -331,7 +331,12 @@ def build_schema(Type) -> Schema:
 
         if not (is_dataclass(Type) or is_namedtuple(Type)):
             raise TypeNotSupported(type_=Type)
-        hints = get_type_hints(Type)
+        try:
+            hints = get_type_hints(Type)
+        except TypeError as te:
+            # this can happen for instance on 3.9 if pipe syntax was used for Union types
+            # would be nice to provide a friendlier error though
+            raise TypeNotSupported(type_=Type) from te
         fields = tuple((k, build_schema(t)) for k, t in hints.items())
         return SDataclass(
             type=Type,