Don't crash benchcomp when rounding non-numeric values #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency upgrade resulting from `cargo update`. Co-authored-by: tautschnig <[email protected]>
…3202) Bumps [tests/perf/s2n-quic](https://github.com/aws/s2n-quic) from `f5d9d74` to `d03cc47`. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/aws/s2n-quic/commit/d03cc470fa9812d06d204e312e4ada00079e96df"><code>d03cc47</code></a> docs(s2n-quic): fips mode usage with rustls TLS provider (<a href="https://redirect.github.com/aws/s2n-quic/issues/2224">#2224</a>)</li> <li><a href="https://github.com/aws/s2n-quic/commit/275dbfdf4a4072f4c620abf9849ca268d8bcdb46"><code>275dbfd</code></a> chore(s2n-quic-transport): update dc manager dot snapshot (<a href="https://redirect.github.com/aws/s2n-quic/issues/2223">#2223</a>)</li> <li><a href="https://github.com/aws/s2n-quic/commit/41ebf0c2ca92674412f9e70a35339b2da9f4f738"><code>41ebf0c</code></a> test(s2n-quic-core): add microwave state example (<a href="https://redirect.github.com/aws/s2n-quic/issues/2222">#2222</a>)</li> <li><a href="https://github.com/aws/s2n-quic/commit/391068e5f613b82bb465444eac88bbd278afc9e7"><code>391068e</code></a> feat(s2n-quic-transport): dc Manager (<a href="https://redirect.github.com/aws/s2n-quic/issues/2218">#2218</a>)</li> <li><a href="https://github.com/aws/s2n-quic/commit/c96e57c83c5cfe53e5da9beb26a610054c8a9333"><code>c96e57c</code></a> feat(s2n-quic-core): generate state reactions to events (<a href="https://redirect.github.com/aws/s2n-quic/issues/2221">#2221</a>)</li> <li><a href="https://github.com/aws/s2n-quic/commit/f23d87bbaad3ff58b65f1d23fff2e1b71754b870"><code>f23d87b</code></a> feat(s2n-quic-core): allow for branching states on common events (<a href="https://redirect.github.com/aws/s2n-quic/issues/2219">#2219</a>)</li> <li><a href="https://github.com/aws/s2n-quic/commit/5cac7eaae62fa08e88e00a5bc456e846334e98c8"><code>5cac7ea</code></a> build(deps): bump JamesIves/github-pages-deploy-action (<a href="https://redirect.github.com/aws/s2n-quic/issues/2215">#2215</a>)</li> <li><a href="https://github.com/aws/s2n-quic/commit/0f17963d8e6fbf7f6a5ab76f0ceefc1061cfa1f9"><code>0f17963</code></a> --- (<a href="https://redirect.github.com/aws/s2n-quic/issues/2216">#2216</a>)</li> <li>See full diff in <a href="https://github.com/aws/s2n-quic/compare/f5d9d747805de846181536ecc2c0a6754a98e9ea...d03cc470fa9812d06d204e312e4ada00079e96df">compare view</a></li> </ul> </details> <br /> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…odel-checking#3199) - Linter fixes in documentation, - Added the `lld` package for ubuntu builds, - Propagated a `TyCtx` API change. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses. --------- Co-authored-by: Remi Delmas <[email protected]>
Previously, benchcomp would crash while rendering a scatterplot when some results had non-numeric values, because those values were being rounded using a function that doesn't handle non-numeric arguments. This commit fixes model-checking#3210.
karkhaz
force-pushed
the
kk-fix-scatterplot-crash
branch
from
48589e9
to
a411f81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, benchcomp would crash while rendering a scatterplot when some results had non-numeric values, because those values were being rounded using a function that doesn't handle non-numeric arguments.
This commit fixes model-checking#3210.