Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with n_joints in train.py #73

Closed
Samleo8 opened this issue May 14, 2020 · 3 comments
Closed

Bug with n_joints in train.py #73

Samleo8 opened this issue May 14, 2020 · 3 comments

Comments

@Samleo8
Copy link

Samleo8 commented May 14, 2020

n_joints = keypoints_3d_pred[0].shape[1]

I believe this is an error, because keypoints_3d_pred has shape [<batch_size>, <num_keypoints>, 3].

Therefore, this should be changed to either
n_joints = keypoints_3d_pred.shape[1] or n_joints = keypoints_3d_pred[0].shape[0].

@Samleo8 Samleo8 changed the title Bug with n_joints in train.py Bug with n_joints in train.py May 14, 2020
Samleo8 added a commit to Samleo8/learnable-triangulation-pytorch that referenced this issue May 14, 2020
@uyoung-jeong
Copy link

It seems that n_joints is only used in 1-view case. As long as we don't run it in 1-view setup, it would cause no trouble. By the way, I was surprised that I didn't even notice this problem while I ran the script dozens of times. Thank you!

@Samleo8
Copy link
Author

Samleo8 commented May 29, 2020

Unfortunately even if you don't intend to run it with the 1-view setup, what I found is that sometimes if the CMU dataset has missing BBOX data for certain cameras/frames. If you have 3 cameras/views but 2 of them have invalid BBOXes, the algorithm will take that particular batch as a 1-view case.

@karfly
Copy link
Owner

karfly commented Sep 1, 2020

Oh, missed this issue. Thank you @Samleo8 and @uyoung-jeong, fixed that here: acee6d2

@karfly karfly closed this as completed Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants