Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix npm package vulnerabilities. Fixed react warnings. #7

Merged
merged 3 commits into from
Feb 13, 2019
Merged

Fix npm package vulnerabilities. Fixed react warnings. #7

merged 3 commits into from
Feb 13, 2019

Conversation

PeteLevineA
Copy link

Updated babel-eslint fixes the following high vulnerability:

High Regular Expression Denial of Service
Package minimatch
Dependency of babel-eslint [dev]
Path babel-eslint > babel-core > minimatch
More info https://nodesecurity.io/advisories/118

Updated react-measure fixes the following react errors:

ResizeObserver loop limit exceeded
souporserious/react-measure#104

After these fixes via npm install:

found 0 vulnerabilities

@PeteLevineA
Copy link
Author

@bitriddler Can we also merge master back into develop after this PR is cleared? Also a version bump and npm update would be great for any new potential downloads of this package to no longer get npm security warnings. Thanks!

@kareemaly
Copy link
Owner

@PeteLevineA thanks for your pr, I'll check today and will spend some time to bump all versions 👍

@kareemaly kareemaly changed the base branch from master to develop February 13, 2019 13:25
@kareemaly
Copy link
Owner

I will merge this into develop and do some checking and update the rest of dependencies

@kareemaly kareemaly merged commit 81a5ca4 into kareemaly:develop Feb 13, 2019
@kareemaly
Copy link
Owner

@PeteLevineA please check https://github.com/bitriddler/react-items-carousel/releases/tag/2.3.0 this should no longer have security warnings (for the moment)

@PeteLevineA
Copy link
Author

@bitriddler looks good, npm install from clean, npm start and running locally runs fine as well. Thank you! please do an npm publish when you can with 2.3.0 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants