Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update regex and disable unneeded features #1

Merged
merged 1 commit into from
Oct 18, 2020
Merged

Update regex and disable unneeded features #1

merged 1 commit into from
Oct 18, 2020

Conversation

link2xt
Copy link
Contributor

@link2xt link2xt commented Oct 18, 2020 •
edited
Loading

No description provided.

@link2xt
Copy link
Contributor Author

link2xt commented Oct 18, 2020

See rust-lang/regex#721 for rationale. Other features can still be enabled by users, but Cargo does not to allow to disable them (for good reason, as it may break dependencies). Libraries should only enable features they actually depend on.

@link2xt link2xt force-pushed the regex-features branch 2 times, most recently from 1605a64 to 5ec4ace Compare October 18, 2020 17:41
@kardeiz kardeiz merged commit 82a34a9 into kardeiz:master Oct 18, 2020
@kardeiz
Copy link
Owner

kardeiz commented Oct 18, 2020

Thanks, you are right about the features! I relaxed the version spec for both dependencies and have released this as sanitize-filename 0.3.0.

@link2xt link2xt deleted the regex-features branch October 18, 2020 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@link2xt @kardeiz