multipart/form-data works via REST client but fails in Karate tests #797 #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nishant-sehgal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ptrthomas
Implementation for resolving MockHttpClient multipart file upload issue.
Issue: #797
Issue was with StandardMultipartHttpServletRequest implementation that in spring-web.Which has started using different case for CONTENT_DISPOSITION header in the request due to which it throws NLP exception.
Have added a fallback in case of header not found to check with lowercase header value that we have in MockMultiPart.
Will work both in spring boot 1 and 2 dependency.
Verified the same in the demo project shared in the issue.
Before change Test case report:
After Change Test case report: