JS engine refactor - graal upgrade - JS functions can be passed around safely #2081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which may be a breakthrough
still an issue with parallel scenario, but no longer the multi-thread issue guess is that variables are being over-written by another scenario-thread websocket may not be possible to do with custom js functions so we will limit or revise existiing documented approach
feels good to get rid of that horrible recurse and attach stuff
in small steps because of how much trouble this caused in the past
note that this commit reverts the change made in #1835
my guess is that this was the source of the flakyness and how we swallowed the exception before
this should be the last of the graal upgrade and js fixes
|
Great achievement! Is there a timeframe in mind for making a formal minor/major release launch? Hard to find time these days but given I experienced some of the pains would like to give it a go and ask a few groups to try this out. |
|
@joelpramos I'll try for this week after going over some of the open issues. yes I agree, this may be a breakthrough ! |
This was referenced Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refer #1883 #2009
a lot of the attach / detach code has gone away and I find the build 10% faster so that's great news
and I hope this resolves the context errors that have given us a hard time