hope this solves the graal js issues with java interop #1558

more details at the issue comments
karatelabs · May 23, 2021 · e4f527a · e4f527a
1 parent 66aeaa3
commit e4f527a
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 4 deletions.
diff --git a/karate-core/src/main/java/com/intuit/karate/core/ScenarioEngine.java b/karate-core/src/main/java/com/intuit/karate/core/ScenarioEngine.java
@@ -1091,7 +1091,7 @@ private Object recurseAndAttach(Object o, Set<Object> seen) {
                     return attach(value);
                 }
             } catch (Exception e) {
-                logger.trace("failed to re-attach graal value (will re-try): {}", e.getMessage());
+                logger.trace("[attach] failed to re-attach graal value (will re-try): {}", e.getMessage());
                 try {
                     return Value.asValue(value.asHostObject());
                 } catch (Exception inner) {
@@ -1142,12 +1142,12 @@ private Object recurseAndAttachAndDeepClone(Object o, Set<Object> seen) {
             // should never happen if the detach was done properly
             Value value = (Value) o;
             try {
-                if (value.canExecute()) {
+                if (value.canExecute() || value.isMetaObject()) {
                     return attach(value);
                 }
                 o = JsValue.toJava(value);
             } catch (Exception e) {
-                logger.trace("failed to re-attach graal value (will re-try): {}", e.getMessage());
+                logger.trace("[attach deep] failed to re-attach graal value (will re-try): {}", e.getMessage());
                 try {
                     return Value.asValue(value.asHostObject());
                 } catch (Exception inner) {

diff --git a/karate-core/src/test/java/com/intuit/karate/core/parajava/ParallelJavaTest.java b/karate-core/src/test/java/com/intuit/karate/core/parajava/ParallelJavaTest.java
@@ -8,7 +8,7 @@
 
 public class ParallelJavaTest {
 
-    // @Test
+    @Test
     public void testParallel() {
         Results results = Runner.path("classpath:com/intuit/karate/core/parajava/parallel-java.feature")
                 .configDir("classpath:com/intuit/karate/core/parajava")

diff --git a/karate-core/src/test/java/com/intuit/karate/graal/JsEngineTest.java b/karate-core/src/test/java/com/intuit/karate/graal/JsEngineTest.java
@@ -192,6 +192,13 @@ void testValueAndHostObject() {
         Value v = Value.asValue(sp);
         assertTrue(v.isHostObject());
     }
+
+    @Test
+    void testJavaType() {
+        Value v = je.evalForValue("Java.type('com.intuit.karate.graal.SimplePojo')");
+        assertTrue(v.isMetaObject());
+        assertTrue(v.isHostObject());
+    }    
 
     @Test
     void testEvalWithinFunction() {