Option to edit the server #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@karasevm Also added a TextView when the items are empty |
|
Looks good to me, thanks for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I (a user of PrivateDNSAndroid) recently updated from version 1.3 to 1.7, wherein the labels were implemented. I immediately wanted to edit my servers but on tapping them I was only presented with an option to delete the server.
Obviously, a user can delete and re-create the entry with a label, but I thought that having an option to edit is much easier.
I have modified the AddServerDialogFragment mainly to also act as the editable dialog when clicked upon and have also added the Delete button which opens the delete dialog.
I primarily work with Flutter and am relatively new to Native Android Development. This is my first contribution so let me know if I could've done any better.
Screenrecording_20240803_170739.mp4