Quick Stream Improvement!!

[thanamaha2002]

After playing with the stream feature I have a new idea for Rclone Browser to improvement and this is a quick one.

I using the mpv player for stream file and it supports setting a window title via command line, for example:

What if we implement a parameter which Rclone Browser will replace it with a file name, it would be nice! for example:

Stream command: .\mpv.exe --title="%file_name%" -

When Rclone Browser run the command it will replace %file_name% with a file name, so the window title of the player will be the filename too!

[kapitainsky]

are there any length restrictions on --title ? Because file names can be very looong.

[thanamaha2002]

On Windows, the maximum command-line length is 32767 characters. Which I think more than enough since when people upload their files from Windows, for example, the full-path length limit is 260 characters. It's the NTFS limitation since Windows NT 3.1... I wish M$ change this non-sense limit.

[thanamaha2002]

I check the Mac OS the full-path length limit around 1016 characters and the Linux is 255 to 4096 characters depending on the disk format.

The maximum command-line length is a lot higher. So, in the very extremely rare case that they will have file name length more than the command line limit length.

(Someone who crazy enough to create or rename file on the cloud with the non-sense looooooong name, if the cloud support file that long name)

[kapitainsky]

I think most filesystems only allow 255 as maximum file name length
but question is about mpv player --title parameter. Will it accept 255 character? Could you check?

I am only thinking about $FileName variable containing only file name (without full path)

[kapitainsky]

And note to myself:) for VLC

"/Applications/VLC.app" --meta-title "window title" -

--meta-title can be 255 character long

[thanamaha2002]

I manage to find the limit length of mpv --title by brute force because I can't find this information in the mpv's docs ...

The limit of mpv --title length is exactly 1,000 characters.

[thanamaha2002]

I tested with the prohibited characters \, /, :, *, ?, <, >, | on Windows, it also works but not with the " it not show this characters on the window title (read below).

And after testing it's safer to use command like this .\mpv.exe - --title="test" than this .\mpv.exe --title="test" -

Because if we have " in the file name it will bug and mpv window won't show if the command is .\mpv.exe --title="\/:*?<>|"" -

But with this .\mpv.exe - --title="\/:*?<>|"" it works, just not show " on the window title (see pictures below).

So, for your VLC is /Applications/VLC.app" - --meta-title "window title"

[kapitainsky]

Oki - so we know how to do it. I will add $FileName variable and toolTip explanation for end users how to use it.

…

On 12 Mar 2020, at 08:48, Thanachai Mahanakorn ***@***.***> wrote: I tested with the prohibited characters \, /, :, *, ?, <, >, | on Windows, it also works but not with the " it not show this characters on the window title (read below). And after testing it's safer to use command like this .\mpv.exe - --title="test" than this .\mpv.exe --title="test" - Because if we have " in the file name it will bug and mpv window won't show if the command is .\mpv.exe --title="\/:*?<>|"" - But with this .\mpv.exe - --title="\/:*?<>|"" it works, just not show " on the window title (see pictures below). <https://user-images.githubusercontent.com/35872889/76502999-9dd3a300-6477-11ea-93d0-0d807886bc19.png> <https://user-images.githubusercontent.com/35872889/76502996-9c09df80-6477-11ea-8acc-908c325c78ef.png> So, for your VLC is /Applications/VLC.app" - --meta-title "window title" — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#90 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADXJHORX4PPU5NCMFV5QSLTRHCOXDANCNFSM4LGDVLUA>.

[thanamaha2002]

I want to test this if you have a free time to compile for me, thanks. :)

[kapitainsky]

This feature is not implemented yet. It will be for sure. I am working on other features atm. When I have it stable I will send you beta. Tests are always welcomed.

…

On 16 Mar 2020, at 02:57, Thanachai Mahanakorn ***@***.***> wrote:  I want to test this if you have a free time to compile for me, thanks. :) — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

[kapitainsky]

you test #93 (comment)

file name substitution is $file_name

[thanamaha2002]

Then, I'll close this issue and I'll report on that one instead. Thank for your hard-work!

[kapitainsky]

command copy issue has been fixed. It will make into final release.