Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended mount functionality #52

Open
caspertone2003 opened this issue Dec 5, 2019 · 35 comments
Open

Extended mount functionality #52

caspertone2003 opened this issue Dec 5, 2019 · 35 comments
Labels
enhancement New feature or request will be fixed in the next relase fix is already done and will be included in the next release
Milestone

Comments

@caspertone2003
Copy link

Some (more) proposals

a) Directory navigation
Using the GUI or mounting gives long time to navigate the tree under Windows 10. I do not know how you approach to this (rclone) issue.
Perhaps some configuration could be added. See https://forum.rclone.org/t/how-to-get-full-directory-tree-cached-on-first-mount/12535

b) would be nice to get output as rclone tree does
https://rclone.org/commands/rclone_tree/

Thanks for considering

@kapitainsky
Copy link
Owner

kapitainsky commented Dec 5, 2019 via email

@caspertone2003
Copy link
Author

I am struggling with mounts in windows for months...
Even tried with MegaCMD but it fails miserably with big files transfers... And I find their sw buggy and stutters from time to time such as

@kapitainsky
Copy link
Owner

regarding mounts - this is big story and there is no one solution good for everyone especially that different options might work different for different remotes. What I can do here is to provide even more flexibility and introduce mounting scripts e.g. you could run your cache seeding script after successful mount.

@kapitainsky
Copy link
Owner

also I don't fully understand why to rely on mounts... It is useful to look around and do some small tasks but will never work for bigger operations e.g. trying to sync 1 million files over mount is designed to fail.

They will never work perfectly. It is just very inefficient way of working with remote object storage in name of convenience. Risk of data being lost or corruption is huge in my opinion. When you use file manager e.g. explorer in windows to perform operations on "fake" filesystem you are using wrong tools. File managers is not aware of real nature of such mounted filesystem and treats it as "local" one. Fuse software tries hard to simulate local filesystem behaviour but it is only virtualization of some kind.

@kapitainsky
Copy link
Owner

for mounting remotes you could maybe have a look at these solutions:

https://github.com/dimitrov-adrian/RcloneTray
https://mountainduck.io/

I would prefer Rclone Browser to be a browser:) And hopefully good one. Mounting option is there because it was originally implemented and I did not want to provide less features than original version. Legacy is legacy.

@kapitainsky
Copy link
Owner

I will create wiki page regarding mounts as things like you found for example (https://forum.rclone.org/t/how-to-get-full-directory-tree-cached-on-first-mount/12535) are definitely worth to share

@kapitainsky
Copy link
Owner

b) would be nice to get output as rclone tree does
https://rclone.org/commands/rclone_tree/

For tree I am thinking about adding it the same way like size option but only to display directories structure: rclone tree -d

What do you think?

@dia3olik
Copy link

dia3olik commented Dec 7, 2019

Yeah it would be great to have a quick glimpse of the dir structure

@kapitainsky kapitainsky added the enhancement New feature or request label Dec 8, 2019
@kapitainsky
Copy link
Owner

Tree command has been added in the latest release

@caspertone2003
Copy link
Author

caspertone2003 commented Feb 19, 2020

@kapitainsky

Hi, long time not here for different reasons - not RcloneBrowser related.

Thanks for 1.8.0, took some time, come with lots of enhancements.

In relation to mount, I see what you mean. But it is convenient as hell ... While feels like a treason to rclone, I am currently using MegaCMD for mounting mega in windows with more or less acceptable results. It is possible to work with mounts using winfsp and rclone using CMD (no need for RCloneTray) but has glitches, and only gets well using dos based explorers (norton commander alike) - not found anyone working with mouse and not in a mad manner.
By the way, I imagine you are aware that now rclone is able to handle (safely) unmounts in windows!

DirTree is interesting and useful. I wish not to sound ungrateful... Helps to navigate... I would love to see the main pane of the remote showing the tree, I mean, when one connects to the remote, having all tree displayed and not having to click and wait, and go level by level down of the tree... So that I would be able to directly click in a deep 4 folder and see its contents... perhaps for a future enrichment?

Thanks for all your excellent work with RB!

CT

@kapitainsky
Copy link
Owner

By the way, I imagine you are aware that now rclone is able to handle (safely) unmounts in windows!

It is supported in RcloneBrowser since version 1.6.0 and actually rclone implemented it because of our requirement - rclone/rclone#3575

DirTree is interesting and useful. I wish not to sound ungrateful... Helps to navigate... I would love to see the main pane of the remote showing the tree, I mean, when one connects to the remote, having all tree displayed and not having to click and wait, and go level by level down of the tree... So that I would be able to directly click in a deep 4 folder and see its contents... perhaps for a future enrichment?

I totally agree with your comment on browsing experience. I like the idea with navigable remote tree. Definitely something I would like to see implemented.

@kapitainsky
Copy link
Owner

kapitainsky commented Mar 12, 2020

Finally I return to this issue. I am going to rewrite mounting code. These are things I plan to include:

Anything else you can think of?

@kapitainsky kapitainsky added the feedback needed feedback needed label Mar 12, 2020
@kapitainsky kapitainsky changed the title Directory Caching and Tree command Extended mount functionality Mar 12, 2020
@Darthagnon
Copy link

I assume the option to "save Mount as a task" will include creation and removal of said task as well? (e.g. otherwise users would have to go into Services.msc or something to delete the task)

@kapitainsky
Copy link
Owner

It would work the same way as now Download/Upload tasks. You save it as RcloneBrowser task.
So you could edit/run/delete it

@kapitainsky
Copy link
Owner

kapitainsky commented Mar 12, 2020

I will not do any OS specific services changes. Idea is you create your Mount Tasks - and if you mark them as "auto start" every time you start RB they will run - so all your mounts will be mounted. Then you can close RB to system tray icon (this is already implemented).

@Darthagnon
Copy link

That's perfect!

I had forgotten RCloneBrowser's wide OS support, and mistakenly assumed that saving mounts as "tasks" was a reference to Windows background services.

@Darthagnon
Copy link

Darthagnon commented Mar 12, 2020

Wondering, is it possible for mounted drives to have custom icons? I don't know if it's a limitation of RClone, or my Windows 10 system, or what, but some current mounts have a "blank file" icon.

Apologies if this is beyond the scope of this update

EDIT: e.g. OneDrive Enterprise has a standard drive icon, but Mega.nz has a blank file icon

@Darthagnon
Copy link

Just noticed that I can't find an un-mount option in the context menu of v1.8.0 - not sure if I've missed something, otherwise could I feature-request it for the update?

  • Un-mount remote command from context menu

@kapitainsky
Copy link
Owner

No custom icons. Mounted remote will be represented by whatever standard "mount" icon your OS is using. Customizing icons is just make it pretty story - unfortunately it would be different work on every OS - too much to do.

@kapitainsky
Copy link
Owner

kapitainsky commented Mar 12, 2020

Just noticed that I can't find an un-mount option in the context menu of v1.8.0 - not sure if I've missed something, otherwise could I feature-request it for the update?

* Un-mount remote command from context menu

it is rclone limitation not rclone browser. you might request it from them.
Rclone browser simply runs:

rclone mount remote: Z:

what is happening after - icon, context menu etc. is out of browser scope

@Darthagnon
Copy link

Darthagnon commented Mar 12, 2020

Fair enough; will do!

EDIT: in #13 it sounds like unmount was already implemented? Here it sounds like a Ctrl+C or hard kill command is handled is handled effectively by RClone, and this page suggests that failsafes are built in: hard unmount fails if the mount is busy.

EDIT2: I just found this. Looks like you've already considered it. My bad.

@kapitainsky
Copy link
Owner

kapitainsky commented Mar 12, 2020

Fair enough; will do!

EDIT: in #13 it sounds like unmount was already implemented? Here it sounds like a Ctrl+C or hard kill command is handled is handled effectively by RClone, and this page suggests that failsafes are built in: hard unmount fails if the mount is busy.

EDIT2: I just found this. Looks like you've already considered it. My bad.

Unmount from within RB - you are asking for right click context menu option in explorer.

At the moment in Windows rclone mounted drive does not have it:

RBScreenshot 2020-03-12 at 13 32 08

when for example mounted network drives have "Disconnect" option:

Screenshot 2020-03-12 at 13 31 45

if this is what you are after you have to talk to rclone people.

@Darthagnon
Copy link

Oops, my bad phrasing - I wasn't talking about Explorer, I was referring to within RCloneBrowser - when I open a remote and right-click on it, the list of options is:

  • Refresh
  • DirTree
  • Export
  • New Folder
  • Rename
  • Move
  • Delete
  • Mount
  • [UnMount is missing]
  • Stream
  • Upload
  • Download
  • Public Link

@kapitainsky
Copy link
Owner

Oops, my bad phrasing - I wasn't talking about Explorer, I was referring to within RCloneBrowser - when I open a remote and right-click on it, the list of options is:

This is remote content view. Why it should have unmount option? Unmount is not associated with specific remote folder but with mount point - in case of windows with drive letter you mounted resource to.

You can have many mount points pointing to the same resource.

To unmount drive in RB go to jobs and stop mount job.

@Darthagnon
Copy link

Apologies; I didn't realise I could stop the mount job; that solves my issue! I've just realised there's an [X] button on jobs (didn't see it before, because black on dark gray background, dim screen).

@kapitainsky
Copy link
Owner

kapitainsky commented Mar 12, 2020 via email

@kapitainsky kapitainsky added the will be fixed in the next relase fix is already done and will be included in the next release label Mar 13, 2020
@kapitainsky
Copy link
Owner

Slowly getting there:

Screenshot 2020-03-13 at 20 38 42

@kapitainsky
Copy link
Owner

beta version is ready for testing:

#93 (comment)

@caspertone2003
Copy link
Author

caspertone2003 commented Mar 20, 2020

RB is but will be more in my paradise ...
I am short of time - to much covid-19 work / will try to test beta over the weekend.
Wish you all are in good health
Thanks
CT

@kapitainsky
Copy link
Owner

kapitainsky commented Mar 21, 2020

This work is done thanks to covid-19... As I can't do other things. I will call it "pandemic edition". You will see that it is not only mount that changes:)

And please use this thread for any comments you might have re mounting:

#93 (comment)

@kapitainsky kapitainsky removed the feedback needed feedback needed label Mar 21, 2020
@kapitainsky kapitainsky added this to the 2.0.0 milestone Mar 21, 2020
@caspertone2003
Copy link
Author

caspertone2003 commented Mar 22, 2020

Comments left in the other thread - #93

You wrote some comments above that you were not seen the use case of mount.
Well, for me it is very useful. For renaming, moving and editing -all manually - many small files.
So, I use all the funtionalities of explorer or copycats alternatives.

;-)

@kapitainsky
Copy link
Owner

kapitainsky commented Mar 22, 2020 via email

@caspertone2003
Copy link
Author

By the way, while dirtree is not my dream, is certainly useful.
Could it be much complex to add an export button, exporting the listing in xml? we could use xml browsers to open the file such as http://www.java2s.com/Code/CSharp/GUI-Windows-Form/ReadanXMLDocumentanddisplaythefileasaTree.htm so that it is possible to collapse branches...
Who knows, there could even be a library that you could use to show/collapse branches...

Thanks again! We users do not stop to ask....
CT

@TimetravelerDD
Copy link

TimetravelerDD commented Sep 23, 2020

[...]

  • add task option "run automatically" on Rclone Browser start
    [...]
    Anything else you can think of?

That would make my dream come true!

two more ideas:

  • the option to start RB automatically after windows boots
  • specific mount options for each remote

@vvpnet
Copy link

vvpnet commented Mar 2, 2023

Slowly getting there:

Screenshot 2020-03-13 at 20 38 42

Hi. I can't find how to save the mount point automatically? I have version 1.61.1 of Linux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request will be fixed in the next relase fix is already done and will be included in the next release
Projects
None yet
Development

No branches or pull requests

6 participants