Remove faust-cchardet dep #127
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lib is an optimization only Removing it per kapi2289#126 (comment) Also PEP 517 wheel builds are currently failing for the lib faust-streaming/cChardet#22 (comment)
19 tasks
|
https://github.com/faust-streaming/cChardet/releases/tag/v2.1.18 should fix the wheel build issue so if https://github.com/home-assistant/core/actions/runs/4235973568/jobs/7360251765 passes, this PR likely isn't needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lib was switched out in #126 but since this lib is an optimization only and currently failing PEP 517 builds faust-streaming/cChardet#22 (comment), removing it per #126 (comment)
@kapi2289 Apologizes for the additional churn