Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make docker-in-docker DOCKER_CONFIG configurable #242

Merged
merged 1 commit into from
Aug 27, 2019
Merged

Make docker-in-docker DOCKER_CONFIG configurable #242

merged 1 commit into from
Aug 27, 2019

Conversation

tdmanv
Copy link
Contributor

@tdmanv tdmanv commented Aug 27, 2019

Change Overview

Pull request type

Please check the type of change your PR introduces:

  • Work in Progress
  • Refactoring (no functional changes, no api changes)
  • Trival/Minor
  • Bugfix
  • Feature
  • Documentation

Test Plan

Manually login and logout

make shell
launching a shell in the containerized build environment
/go/src/github.com/kanisterio/kanister # docker login
Authenticating with existing credentials...
WARNING! Your password will be stored unencrypted in /root/.docker/config.json.
Configure a credential helper to remove this warning. See
https://docs.docker.com/engine/reference/commandline/login/#credentials-store

Login Succeeded
/go/src/github.com/kanisterio/kanister #
  • Manual
  • Unit test
  • E2E

@tdmanv tdmanv merged commit 0afea73 into master Aug 27, 2019
@tdmanv tdmanv deleted the docker-cfg branch August 27, 2019 01:26
julio-lopez added a commit that referenced this pull request Sep 14, 2023
@julio-lopez
deps(gha): use commit id for docker/metadata-action version
50c6348 
Upgrades the action to 96383f45573cb7f253c731d3b3ab81c87ef81934 # v5.0.0

Release notes:

Release notes
Sourced from docker/metadata-action's releases.

v5.0.0
Node 20 as default runtime (requires Actions Runner v2.308.0 or later) by @​crazy-max in docker/metadata-action#328
Bump @​actions/core from 1.10.0 to 1.10.1 in docker/metadata-action#333
Bump csv-parse from 5.4.0 to 5.5.0 in docker/metadata-action#320
Bump semver from 7.5.1 to 7.5.2 in docker/metadata-action#304
Bump handlebars from 4.7.7 to 4.7.8 in docker/metadata-action#315
Full Changelog: docker/[email protected]

v4.6.0
Dedup and sort labels by @​crazy-max in docker/metadata-action#301
Bump @​docker/actions-toolkit from 0.3.0 to 0.5.0 in docker/metadata-action#302
Full Changelog: docker/[email protected]

v4.5.0
Bump @​docker/actions-toolkit from 0.1.0 to 0.3.0 in docker/metadata-action#296
Bump csv-parse from 5.3.8 to 5.4.0 in docker/metadata-action#294
Full Changelog: docker/[email protected]

v4.4.0
Add context input to define the metadata provider by @​neilime in docker/metadata-action#248
Switch to actions-toolkit implementation by @​crazy-max in docker/metadata-action#266 docker/metadata-action#273 docker/metadata-action#284
Bump csv-parse from 5.3.3 to 5.3.8 in docker/metadata-action#271 docker/metadata-action#286
Bump moment-timezone from 0.5.40 to 0.5.43 in docker/metadata-action#268 docker/metadata-action#278 docker/metadata-action#281
Bump semver from 7.4.0 to 7.5.0 in docker/metadata-action#285
Full Changelog: docker/[email protected]

v4.3.0
Provide outputs as env vars by @​crazy-max (#257)
Full Changelog: docker/[email protected]

v4.2.0
Add tz attribute to handlebar date function by @​chroju (#251)
Bump minimatch from 3.0.4 to 3.1.2 (#242)
Bump csv-parse from 5.3.1 to 5.3.3 (#245)
Bump json5 from 2.2.0 to 2.2.3 (#252)
Full Changelog: docker/[email protected]

v4.1.1
Revert changes to set associated head sha on pull request event by @​crazy-max (#239)
User can still set associated head sha on PR by setting the env var DOCKER_METADATA_PR_HEAD_SHA=true
Bump csv-parse from 5.3.0 to 5.3.1 (#237)
Full Changelog: docker/[email protected]

... (truncated)

Ref #2332
julio-lopez added a commit that referenced this pull request Sep 14, 2023
@dependabot @julio-lopez
Bump docker/build-push-action from 4 to 5 (#2328)
f93f456 
* Bump docker/build-push-action from 4 to 5

Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 4 to 5.
- [Release notes](https://github.com/docker/build-push-action/releases)
- [Commits](docker/build-push-action@v4...v5)

---
updated-dependencies:
- dependency-name: docker/build-push-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

* deps(gha): use commit id for docker/build-push-action version

* deps(gha): use commit id for docker/login-action version

* deps(gha): use commit id for docker/metadata-action version

Upgrades the action to 96383f45573cb7f253c731d3b3ab81c87ef81934 # v5.0.0

Release notes:

Release notes
Sourced from docker/metadata-action's releases.

v5.0.0
Node 20 as default runtime (requires Actions Runner v2.308.0 or later) by @​crazy-max in docker/metadata-action#328
Bump @​actions/core from 1.10.0 to 1.10.1 in docker/metadata-action#333
Bump csv-parse from 5.4.0 to 5.5.0 in docker/metadata-action#320
Bump semver from 7.5.1 to 7.5.2 in docker/metadata-action#304
Bump handlebars from 4.7.7 to 4.7.8 in docker/metadata-action#315
Full Changelog: docker/[email protected]

v4.6.0
Dedup and sort labels by @​crazy-max in docker/metadata-action#301
Bump @​docker/actions-toolkit from 0.3.0 to 0.5.0 in docker/metadata-action#302
Full Changelog: docker/[email protected]

v4.5.0
Bump @​docker/actions-toolkit from 0.1.0 to 0.3.0 in docker/metadata-action#296
Bump csv-parse from 5.3.8 to 5.4.0 in docker/metadata-action#294
Full Changelog: docker/[email protected]

v4.4.0
Add context input to define the metadata provider by @​neilime in docker/metadata-action#248
Switch to actions-toolkit implementation by @​crazy-max in docker/metadata-action#266 docker/metadata-action#273 docker/metadata-action#284
Bump csv-parse from 5.3.3 to 5.3.8 in docker/metadata-action#271 docker/metadata-action#286
Bump moment-timezone from 0.5.40 to 0.5.43 in docker/metadata-action#268 docker/metadata-action#278 docker/metadata-action#281
Bump semver from 7.4.0 to 7.5.0 in docker/metadata-action#285
Full Changelog: docker/[email protected]

v4.3.0
Provide outputs as env vars by @​crazy-max (#257)
Full Changelog: docker/[email protected]

v4.2.0
Add tz attribute to handlebar date function by @​chroju (#251)
Bump minimatch from 3.0.4 to 3.1.2 (#242)
Bump csv-parse from 5.3.1 to 5.3.3 (#245)
Bump json5 from 2.2.0 to 2.2.3 (#252)
Full Changelog: docker/[email protected]

v4.1.1
Revert changes to set associated head sha on pull request event by @​crazy-max (#239)
User can still set associated head sha on PR by setting the env var DOCKER_METADATA_PR_HEAD_SHA=true
Bump csv-parse from 5.3.0 to 5.3.1 (#237)
Full Changelog: docker/[email protected]

... (truncated)

Ref #2332

* deps(gha): upgrade the setup-buildx-action to v3.0.0

Uses commit id for docker/setup-buildx-action version

Release notes at https://github.com/docker/setup-buildx-action/releases/tag/v3.0.0

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Julio <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavannd1 pavannd1 pavannd1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tdmanv @pavannd1