An Implementation in Python with a Compiler #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This took me a while.. and I need to redo the other operators. So far only def! and +-*/ works.
Make it verbose and more easily debuggable.
I feel the compiler should do more work, other than just delegating.
1. COMPILE now takes ast of function type. 2. Support eval and debugger toggle.
(by cheating I mean deferring compilation)
Made some changes that I don't fully understand. It's not working yet. I think I know what to do in the following ocmmits.
It's still a mess and unusable now. But I know what to do now. When an AST (A) gets compiled, the end result is a code (C) to be executed. Execution of C should return a *closure* (not a function, which I've been doing, which is wrong), that holds a slot telling the function where to look for literals (e.g. scalars, functions, objects.. etc). So far I've been trying to save those literals in a global constant _consts. It was why my code failed so far because some compiled ASTs may be alive even after the next compilation. As a consequence, as they are reading from the global _consts, they read the wrong data.
The closure way is the right way to go. Woo hoo :)
make "test^python-compile^step6"
Pass test 4, 5 (except the last one), 6.
test^python-compile^step3~7
|
@jcguu95 If it can be restructured to fit the code layout of other implementations (https://github.com/kanaka/mal/blob/master/docs/FAQ.md#code_split) then I would be willing to consider merging it. Otherwise, if that's too complicated or unwieldy then keeping it separate is probably best. Although I would be happy to include a link to it in the top level README if you like in the "External Implementations" section. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Joel Martin! Thanks for your inspiring work! Based on your python implementation, I implemented a compiled version:
python-compile. It passes all relevant tests (forstep2tostepA, regular and soft), and it is 16 times faster per the performance test suite.Would you like to merge this, or would you rather keep this maintained separately? Please let me know.
Cheers,
Jin