fix(actors): address codeql complaint (filecoin-project#12454)

kamuik16 · Sep 12, 2024 · e4a9614 · e4a9614
1 parent c72c6ac
commit e4a9614
Show file tree

Hide file tree

Showing 4 changed files with 71 additions and 58 deletions.
diff --git a/chain/actors/builtin/multisig/actor.go.template b/chain/actors/builtin/multisig/actor.go.template
@@ -125,29 +125,6 @@ type ProposeReturn = msig{{.latestVersion}}.ProposeReturn
 type ProposeParams = msig{{.latestVersion}}.ProposeParams
 type ApproveReturn = msig{{.latestVersion}}.ApproveReturn
 
-func txnParams(id uint64, data *ProposalHashData) ([]byte, error) {
-	params := msig{{.latestVersion}}.TxnIDParams{ID: msig{{.latestVersion}}.TxnID(id)}
-	if data != nil {
-		if data.Requester.Protocol() != address.ID {
-			return nil, xerrors.Errorf("proposer address must be an ID address, was %s", data.Requester)
-		}
-		if data.Value.Sign() == -1 {
-			return nil, xerrors.Errorf("proposal value must be non-negative, was %s", data.Value)
-		}
-		if data.To == address.Undef {
-			return nil, xerrors.Errorf("proposed destination address must be set")
-		}
-		pser, err := data.Serialize()
-		if err != nil {
-			return nil, err
-		}
-		hash := blake2b.Sum256(pser)
-		params.ProposalHash = hash[:]
-	}
-
-	return actors.SerializeParams(&params)
-}
-
 func AllCodes() []cid.Cid {
 	return []cid.Cid{ {{range .versions}}
         (&state{{.}}{}).Code(),

diff --git a/chain/actors/builtin/multisig/message.go.template b/chain/actors/builtin/multisig/message.go.template
diff --git a/chain/actors/builtin/multisig/message0.go b/chain/actors/builtin/multisig/message0.go
diff --git a/chain/actors/builtin/multisig/multisig.go b/chain/actors/builtin/multisig/multisig.go
@@ -243,29 +243,6 @@ type ProposeReturn = msig15.ProposeReturn
 type ProposeParams = msig15.ProposeParams
 type ApproveReturn = msig15.ApproveReturn
 
-func txnParams(id uint64, data *ProposalHashData) ([]byte, error) {
-	params := msig15.TxnIDParams{ID: msig15.TxnID(id)}
-	if data != nil {
-		if data.Requester.Protocol() != address.ID {
-			return nil, xerrors.Errorf("proposer address must be an ID address, was %s", data.Requester)
-		}
-		if data.Value.Sign() == -1 {
-			return nil, xerrors.Errorf("proposal value must be non-negative, was %s", data.Value)
-		}
-		if data.To == address.Undef {
-			return nil, xerrors.Errorf("proposed destination address must be set")
-		}
-		pser, err := data.Serialize()
-		if err != nil {
-			return nil, err
-		}
-		hash := blake2b.Sum256(pser)
-		params.ProposalHash = hash[:]
-	}
-
-	return actors.SerializeParams(&params)
-}
-
 func AllCodes() []cid.Cid {
 	return []cid.Cid{
 		(&state0{}).Code(),