Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for IE 8 compatibility #45

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

seneyr
Copy link

@seneyr seneyr commented Jun 27, 2018

This should fix IE 8 compatibility in regards to issue #44 I added. Per the jQuery documentation (https://api.jquery.com/jQuery/#jQuery2) "class" is a reserved keyword in JavaScript. More recent browsers seem to deal with this fine, but IE 8 will try and interpret class regardless of context which is why it's not working with IE 8. Or at least that's the behavior I'm seeing in the version provided by the IE 8 VM on modern.ie

@sgbeal
Copy link

sgbeal commented Nov 12, 2018

A simpler fix, i suspect (but can't test), would be to simply replace the class identifier with "class".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants