Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement test_any and wait_any #625

Merged
merged 5 commits into from
Feb 14, 2024
Merged

Implement test_any and wait_any #625

merged 5 commits into from
Feb 14, 2024

Conversation

niklas-uhl
Copy link
Member

No description provided.

Copy link
Member

@mschimek mschimek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only some very small issues

@@ -24,6 +34,16 @@ class RequestPool {

using index_type = size_t; ///< The type used to index requests in the pool.

/// @brief The first index value. The pool is empty if `index_begin() == index_end()`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why isn't doxygen complaining about the (here redundant but) missing @return?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you just have @brief, then no other documentation is required.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to know^^

include/kamping/request_pool.hpp Show resolved Hide resolved
include/kamping/request_pool.hpp Outdated Show resolved Hide resolved
@niklas-uhl niklas-uhl merged commit 7c9ec34 into main Feb 14, 2024
8 checks passed
@niklas-uhl niklas-uhl deleted the feature/test-and-wait-any branch February 14, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants