Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .bcast() #192

Merged
merged 70 commits into from
Jun 24, 2022
Merged

Add .bcast() #192

merged 70 commits into from
Jun 24, 2022

Commits on Mar 25, 2022

  1. Rework the Span<> class, add SingleElementModifyableBuffer, fix resiz… 

    …ing .get_ptr()

* Rework the Span<> class to be more similar with C++20's std::span.
* Add a SingleElementModifyableBuffer using the new Span<>'s interface.
* Update the existing Buffers' interface to use the new Span<>
* Split the existing Buffers' .get_ptr() into .resize() and .data()
* Adjust allreduce and alltoall to use the new Span<> and Buffers
    Lukas Hübner committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    4f8b20d View commit details
    Browse the repository at this point in the history

  2. Add the collective operation broadcast (bcast).

    Lukas Hübner committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    69f7a9c View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2022

  1. Merge branch 'main' into feature-bcast

    Lukas Hübner committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    8f32da0 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2022

  1. Move a const to the east side

    Lukas Hübner committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    9b82c17 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2022

  1. Clean up code

    Lukas Hübner committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    2f83c1a View commit details
    Browse the repository at this point in the history

  2. Let bcast()'s test run on a single core.

    Lukas Hübner committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    4e9d8bc View commit details
    Browse the repository at this point in the history

  3. Add @todo's to bcast()

    Lukas Hübner committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    8cd3f4a View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into feature-bcast

    Lukas Hübner committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    a7ff782 View commit details
    Browse the repository at this point in the history

  5. Re-add the inclusion of communicator.hpp into gather.hpp

    Lukas Hübner committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    c68cb6f View commit details
    Browse the repository at this point in the history

  6. Re-order MPI-using unit tests

    Lukas Hübner committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    0e429af View commit details
    Browse the repository at this point in the history

  7. Adjust bcast() to use the updated MPIResult()

    Lukas Hübner committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    4d2df90 View commit details
    Browse the repository at this point in the history

  8. Apply the new .clang-format to bcast() files.

    Lukas Hübner committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    d68d556 View commit details
    Browse the repository at this point in the history

  9. Remove recursive include

    Lukas Hübner committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    dc3a542 View commit details
    Browse the repository at this point in the history

  10. Add two useful overloads for Communicator::is_root()

    Lukas Hübner committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    22d3ccc View commit details
    Browse the repository at this point in the history

  11. Restructure KASSERTs in bcast() to avoid the shortcomings of missing … 

    …short-circuit evaluation.
    Lukas Hübner committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    cc282c0 View commit details
    Browse the repository at this point in the history

  12. Add two useful overloads for Communicator::is_root()

    Lukas Hübner committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    a0dcd36 View commit details
    Browse the repository at this point in the history

  13. Add unit tests for Communicator::is_root()

    Lukas Hübner committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    837d7b2 View commit details
    Browse the repository at this point in the history

  14. Merge branch 'feature-communicator-is-root-overloads' into feature-bcast

    Lukas Hübner committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    d62a532 View commit details
    Browse the repository at this point in the history

  15. Merge branch 'main' into feature-bcast

    Lukas Hübner committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    972239f View commit details
    Browse the repository at this point in the history

Commits on May 12, 2022

  1. Merge branch 'main' into feature-bcast

    @lukashuebner
    lukashuebner committed May 12, 2022
    Configuration menu
    Copy the full SHA
    7445366 View commit details
    Browse the repository at this point in the history

  2. Apply clang-format changes

    @lukashuebner @actions-user
    lukashuebner authored and actions-user committed May 12, 2022
    Configuration menu
    Copy the full SHA
    6dae35b View commit details
    Browse the repository at this point in the history

  3. Merge branch 'feature-bcast' of github.com:KIT-ITI10/kamping into fea… 

    …ture-bcast
    @lukashuebner
    lukashuebner committed May 12, 2022
    Configuration menu
    Copy the full SHA
    64d87e4 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2022

  1. squash this

    @lukashuebner
    lukashuebner committed May 16, 2022
    Configuration menu
    Copy the full SHA
    7db0be9 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2022

  1. sqash this in rebase

    @lukashuebner
    lukashuebner committed May 17, 2022
    Configuration menu
    Copy the full SHA
    0b1f05e View commit details
    Browse the repository at this point in the history

  2. Add MPICommpincator::is_same_on_all_pes(...) helper

    @lukashuebner
    lukashuebner committed May 17, 2022
    Configuration menu
    Copy the full SHA
    75f12ca View commit details
    Browse the repository at this point in the history

  3. Merge branch 'feature-is_same_on_all_pes' into feature-bcast

    @lukashuebner
    lukashuebner committed May 17, 2022
    Configuration menu
    Copy the full SHA
    649b3df View commit details
    Browse the repository at this point in the history

Commits on May 31, 2022

  1. Take parameters by value 

    Co-authored-by: Demian Hespe <[email protected]>
    @lukashuebner @Hespian
    lukashuebner and Hespian authored May 31, 2022
    Configuration menu
    Copy the full SHA
    73ef1f3 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2022

  1. Merge branch 'feature-bcast' of github.com:KIT-ITI10/kamping into fea… 

    …ture-bcast
    @lukashuebner
    lukashuebner committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    942b936 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into feature-bcast

    @lukashuebner
    lukashuebner committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    e451486 View commit details
    Browse the repository at this point in the history

  3. Add bcast to the Communicator

    @lukashuebner
    lukashuebner committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    462c8da View commit details
    Browse the repository at this point in the history

  4. Update documentation on Communicator::bcast

    @lukashuebner
    lukashuebner committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    712339e View commit details
    Browse the repository at this point in the history

  5. Add a parameter factory for send_recv_count

    @lukashuebner
    lukashuebner committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    4245e55 View commit details
    Browse the repository at this point in the history

  6. Rewrite Communicator::bcast

    @lukashuebner
    lukashuebner committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    55d3465 View commit details
    Browse the repository at this point in the history

  7. Rewrite the tests for Communicator::bcast

    @lukashuebner
    lukashuebner committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    1b1f566 View commit details
    Browse the repository at this point in the history

  8. Apply clang-format

    @lukashuebner
    lukashuebner committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    8697408 View commit details
    Browse the repository at this point in the history

  9. Revert extern/gtest-mpi-listener/gtest-mpi-listener.hpp

    @lukashuebner
    lukashuebner committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    0509ad2 View commit details
    Browse the repository at this point in the history

  10. Remove obsolete comments

    @lukashuebner
    lukashuebner committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    ba1623e View commit details
    Browse the repository at this point in the history

  11. Add two additional assertions in Communicator::bcast(...)

    @lukashuebner
    lukashuebner committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    1808c4a View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2022

  1. Merge branch 'main' into feature-bcast

    @lukashuebner
    lukashuebner committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    070ced0 View commit details
    Browse the repository at this point in the history

  2. fixup

    @lukashuebner
    lukashuebner committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    2c10f8b View commit details
    Browse the repository at this point in the history

  3. fixup

    @lukashuebner
    lukashuebner committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    d0ace1a View commit details
    Browse the repository at this point in the history

  4. Remove duplicate tests for Communicator::is_same_on_all_ranks

    @lukashuebner
    lukashuebner committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    b5178f2 View commit details
    Browse the repository at this point in the history

  5. Update comment

    @lukashuebner
    lukashuebner committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    63ef42d View commit details
    Browse the repository at this point in the history

  6. blub

    @lukashuebner
    lukashuebner committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    2a94723 View commit details
    Browse the repository at this point in the history

  7. Add missing include to bcast.hpp

    @lukashuebner
    lukashuebner committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    50ef63d View commit details
    Browse the repository at this point in the history

  8. Revert send_recv_count's type in bcast() to size_t

    @lukashuebner
    lukashuebner committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    e9ca0cb View commit details
    Browse the repository at this point in the history

  9. Update Communicator::bcast()'s documentation

    @lukashuebner
    lukashuebner committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    3b6fa05 View commit details
    Browse the repository at this point in the history

  10. Remove superflous comments and rename variable for clarity in bcast()

    @lukashuebner
    lukashuebner committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    9988bee View commit details
    Browse the repository at this point in the history

  11. Minor fixes requested by reviewer.

    @lukashuebner
    lukashuebner committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    f91e88b View commit details
    Browse the repository at this point in the history

  12. Merge branch 'main' into feature-bcast

    @lukashuebner
    lukashuebner committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    256280f View commit details
    Browse the repository at this point in the history

  13. Use the new DataBuffer.get_single_element()

    @lukashuebner
    lukashuebner committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    29d6960 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2022

  1. Comments and additional assertions

    @lukashuebner
    lukashuebner committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    7e9ad69 View commit details
    Browse the repository at this point in the history

  2. Resize send_recv_buf also on root rank

    @lukashuebner
    lukashuebner committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    47509a9 View commit details
    Browse the repository at this point in the history

  3. Add test for bcast, testing a message of size 0 (should work)

    @lukashuebner
    lukashuebner committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    7971b24 View commit details
    Browse the repository at this point in the history

  4. Rename send_recv_count to recv_count in bcast()

    @lukashuebner
    lukashuebner committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    4673779 View commit details
    Browse the repository at this point in the history

  5. Fix a bug where user provded recv_counts are ignored in bcast

    @lukashuebner
    lukashuebner committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    5783cbe View commit details
    Browse the repository at this point in the history

  6. Add test for bcast: recv count and vector size differ

    @lukashuebner
    lukashuebner committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    9e11330 View commit details
    Browse the repository at this point in the history

  7. Add check that recv_count == 1 if a single element buffer is passed a… 

    …s send_recv_buf to bcast
    @lukashuebner
    lukashuebner committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    145f007 View commit details
    Browse the repository at this point in the history

  8. Enable recv_count_out in bcast

    @lukashuebner
    lukashuebner committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    362abd0 View commit details
    Browse the repository at this point in the history

  9. Add test for partially transferred containers for bcast()

    @lukashuebner
    lukashuebner committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    5f29ed8 View commit details
    Browse the repository at this point in the history

  10. Remove unneeded send_recv_count parameter.

    @lukashuebner
    lukashuebner committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    024fe11 View commit details
    Browse the repository at this point in the history

  11. Remove unneeded send_recv_count parameter type.

    @lukashuebner
    lukashuebner committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    140adfd View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2022

  1. Incorporate feedback from Demian

    @lukashuebner
    lukashuebner committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    afd4166 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2022

  1. Clean up

    @lukashuebner
    lukashuebner committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    fc546ee View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2022

  1. Merge branch 'main' into feature-bcast

    @lukashuebner
    lukashuebner committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    5baa5c4 View commit details
    Browse the repository at this point in the history

  2. Add some KASSERT_FAILS tests to Communicator::bcast(...)

    @lukashuebner
    lukashuebner committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    edacedd View commit details
    Browse the repository at this point in the history

  3. Mark variable as [[maybe_unused]] in bcast test.

    @lukashuebner
    lukashuebner committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    0b99b71 View commit details
    Browse the repository at this point in the history

  4. Run clang-format

    @lukashuebner
    lukashuebner committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    8eec8d0 View commit details
    Browse the repository at this point in the history

  5. .

    @lukashuebner
    lukashuebner committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    bd75106 View commit details
    Browse the repository at this point in the history

  6. Reformulate comment

    @lukashuebner
    lukashuebner committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    2d4ab53 View commit details
    Browse the repository at this point in the history