Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to define custom router name generator for play server #926

Merged

Conversation

yarosman
Copy link
Contributor

@yarosman yarosman commented Jan 20, 2021

Current operation name are transformed play.api.routing.HandlerDef.path to predefined format and you can't change it

/foo/user/$user<regexp>/blah to /foo/user/user/blah

And now you can define custom operation name generator with format like in the micrometer, and you will have the same template format between java/scala services

/foo/user/$user<regexp>/blah to /foo/user/{user}/blah instead of /foo/user/user/blah

@SimunKaracic
Copy link
Contributor

Hello, please add a small writeup of what this PR is trying to achieve, and I'll get to checking out the PR soon!

@yarosman
Copy link
Contributor Author

yarosman commented Jan 26, 2021

Hello, please add a small writeup of what this PR is trying to achieve, and I'll get to checking out the PR soon!

@SimunKaracic I added description )

@yarosman
Copy link
Contributor Author

yarosman commented Feb 8, 2021

@SimunKaracic did you have time to review this pr ?

@SimunKaracic
Copy link
Contributor

Not yet, we'll get to it this week!

@yarosman yarosman requested a review from ivantopo March 17, 2021 17:03
Copy link
Contributor

@ivantopo ivantopo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @yarosman!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants