Fixed sending message from PC / Fix for ENABLE_MESSENGER_UART #120
Conversation
app/uart.c
Outdated
| #ifdef ENABLE_MESSENGER | ||
| #ifdef ENABLE_MESSENGER_UART | ||
|
|
||
| if (UART_DMA_Buffer[gUART_WriteIndex] == 'S' && UART_DMA_Buffer[gUART_WriteIndex + 1] == 'M' && UART_DMA_Buffer[gUART_WriteIndex + 2] == 'S' && UART_DMA_Buffer[gUART_WriteIndex + 3] == ':') |
There was a problem hiding this comment.
Can we use memcmp() here for cleaner code?
There was a problem hiding this comment.
Was also wondering if we need to require data to start with SMS, instead of sending any serial data that comes in?
So it could be a bit more universal. Are there any implications of this?
There was a problem hiding this comment.
Ohh nevermind I guess reading from CHIRP would then trigger message send. Perhaps in the future it should be limited to only when messenger screen is active.
There was a problem hiding this comment.
maybe if (strncmp(((char*)UART_DMA_Buffer) + gUART_WriteIndex, "SMS:",4) == 0) ?
| @@ -894,5 +886,15 @@ void MSG_ClearPacketBuffer() | |||
| memset(dataPacket.serializedArray, 0, sizeof(dataPacket.serializedArray)); | |||
| } | |||
|
|
|||
| void MSG_Send(const char *cMessage){ | |||
There was a problem hiding this comment.
I like this refactor. Good job!
| @@ -102,3 +103,16 @@ void UART_LogSend(const void *pBuffer, uint32_t Size) | |||
| UART_Send(pBuffer, Size); | |||
| } | |||
| } | |||
|
|
|||
| void UART_printf(const char *str, ...) | |||
There was a problem hiding this comment.
Can we reuse LogUart() from debugging.h ?
There was a problem hiding this comment.
This is not for debug, but for send/recv via serial port. I think it should not be mixed.
|
Seems like the UART receive portion is a bit buggy as it loses some data, ie: |
I saw this once during testing but I thought that it is not on serial print, because at the radio display it also was not complete. |
Send: LED1 - to turn on LED LED2 - to turn on LED Blink LED3 - to turn on LED SOS LED3 - to turn off LED
|
Also adding new feature: ENABLE_MESSENGER_LED - controlling radio led remotely Send: My assumption is to use this along with encryption. This could possibly be enabled in the menu, instead of at compilation level. |
I am partial on this feature, however I see how it might be useful for search & rescue use cases. Couple of suggestions if you decide to submit a new PR with LED control:
|
|
|
||
| ST7565_BlitFullScreen(); | ||
| } | ||
|
|
||
| void UI_DisplayFM(void) | ||
| { | ||
| UI_DisplayFM_text(""); |
There was a problem hiding this comment.
Whereas I like this improvement, the implementation is not slim with the wrapper function approach. And considering we're at 99% mark of space utilization it is quite important.
It could be rewritten to use a global boolean (which probably is already defined, but not used) to indicate scan in progress and then the ui function can determine whether or not display SCN.
…ease, long press EXIT exits monitor mode
Based on MCFW.
You can connect via serial port for sending and receiving messages. For sending just send SMS:Your message. Any time radio receive message it will be send via serial prefixed like SMS>Recived message. I am also planing to make some pythonlib to connect to my rpi and/or make simple web app to support this.