Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #106 #109

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Conversation

T1MOXA
Copy link

@T1MOXA T1MOXA commented Jan 29, 2024

No description provided.

@T1MOXA T1MOXA force-pushed the fix/messenger-roger-error branch from 4d8abbf to 12263a7 Compare January 29, 2024 19:52
Copy link
Owner

@kamilsss655 kamilsss655 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 🎉

There is a small nit that isMessengerPacket should probably be playRoger as the RADIO function shouldn't know about messenger existance. I will refactor it myself in subsequent PR.

Thanks for your help!

@kamilsss655 kamilsss655 merged commit 9c6bfab into kamilsss655:main Jan 30, 2024
VA7FGT pushed a commit to VA7FGT/uv-k5-firmware-custom that referenced this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants