Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mermaid uses ESM modules now. Update so mermaid loads again. #775

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

BobKerns
Copy link
Contributor

@BobKerns BobKerns commented Mar 6, 2023

Since Mermaid has moved to ESM module, the former loading sequence no longer works.

This updates the code generation to use 'import'. The tests are updated and pass. It is deployed (for now) on NPM as @rwk/typedoc-plugin-mermaid.

@kamiazya
Copy link
Owner

kamiazya commented Mar 7, 2023

LGTM!

@kamiazya kamiazya merged commit 2d65301 into kamiazya:main Mar 7, 2023
@kamiazya kamiazya self-assigned this Mar 7, 2023
@kamiazya kamiazya added bug Something isn't working enhancement New feature or request labels Mar 7, 2023
@kamiazya
Copy link
Owner

kamiazya commented Mar 7, 2023

@all-contributors please add @BobKerns for code, bug.

@allcontributors
Copy link
Contributor

@kamiazya

I've put up a pull request to add @BobKerns! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants